Skip to content

Conversation

@IvanGoncharov
Copy link
Member

No description provided.

Copilot AI review requested due to automatic review settings December 7, 2025 15:56
@IvanGoncharov IvanGoncharov added the PR: polish 💅 PR doesn't change public API or any observed behaviour label Dec 7, 2025
@github-actions
Copy link

github-actions bot commented Dec 7, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the GraphQL Voyager graph generation to use the dotviz library's JSON format instead of manually building DOT language strings. The main benefit is improved type safety and maintainability by leveraging dotviz's structured Graph, Node, and Edge types.

  • Refactored getDot() to return a structured Graph object instead of a DOT format string
  • Migrated from string concatenation to building typed nodes and edges arrays
  • Updated graphviz-worker to handle the AggregateError constructor

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
src/graph/dot.ts Complete refactoring from string-based DOT generation to structured Graph object using dotviz types, with extracted helper functions for field labels
src/graph/svg-renderer.ts Added debugging code to render and log the raw DOT format output alongside SVG rendering
src/graph/graphviz-worker.ts Updated AggregateError constructor call (though with an error in the implementation)
cspell.yml Added 'tailport' to the dictionary for the new dotviz terminology

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@IvanGoncharov IvanGoncharov merged commit 3aa74aa into main Dec 8, 2025
17 checks passed
@IvanGoncharov IvanGoncharov deleted the pr_branch branch December 8, 2025 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: polish 💅 PR doesn't change public API or any observed behaviour

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants