Client is not compatible with Jackson 2.20+

[lbenedetto]

Describe the bug

postmark-java/src/main/java/com/postmarkapp/postmark/client/data/parser/DataHandler.java

Line 20 in f8a3620

this.mapper.setPropertyNamingStrategy(PropertyNamingStrategy.UPPER_CAMEL_CASE);

java.lang.NoSuchFieldError: Class com.fasterxml.jackson.databind.PropertyNamingStrategy does not have member field 'com.fasterxml.jackson.databind.PropertyNamingStrategy UPPER_CAMEL_CASE'
	at com.postmarkapp.postmark.client.data.parser.DataHandler.<init>(DataHandler.java:20)
	at com.postmarkapp.postmark.client.data.parser.DataHandler.<init>(DataHandler.java:25)
	at com.postmarkapp.postmark.client.HttpClientHandler.<init>(HttpClientHandler.java:20)
	at com.postmarkapp.postmark.client.BaseApiClient.<init>(BaseApiClient.java:18)
	at com.postmarkapp.postmark.client.ApiClient.<init>(ApiClient.java:55)
	at com.postmarkapp.postmark.Postmark.getApiClient(Postmark.java:62)

PropertyNamingStrategy is deprecated and replaced with PropertyNamingStrategies

There are many other dependencies in this library which are several years out of date, including some with security issues. This project unfortunately seems abandoned.

[elijulian]

running into the same issue

[elijulian]

added a PR: https://github.com/ActiveCampaign/postmark-java/pull/73/files

[elijulian]

response that i got from postmark customer support on this

[jlannoy]

Such answer is a shame. While it's not a bug, not maintaining a library can open vulnerabilities ; that would have severe impacts too. Thank you for trying, offering the immediate solution through a PR.

[lbenedetto]

Another workaround is to shadow the class from Postmark that is outdated.

package com.postmarkapp.postmark.client.data.parser;

import java.io.IOException;
import com.fasterxml.jackson.annotation.JsonInclude;
import com.fasterxml.jackson.core.type.TypeReference;
import com.fasterxml.jackson.databind.DeserializationFeature;
import com.fasterxml.jackson.databind.MapperFeature;
import com.fasterxml.jackson.databind.ObjectMapper;
import com.fasterxml.jackson.databind.PropertyNamingStrategies;
import com.fasterxml.jackson.databind.json.JsonMapper;

/**
 * This shadows the class from the postmark library and rewrites the jackson features using the newest library version.
 * <p>
 * Data serializer/deserializer between API client and HTTP client.
 * It makes sure that proper mechanism is used to convert data to and from data format for HTTP requests and for HTTP
 * responses.
 */
public class DataHandler {

  private final ObjectMapper mapper;

  public DataHandler() {
    this.mapper = JsonMapper.builder()
        .configure(MapperFeature.ACCEPT_CASE_INSENSITIVE_PROPERTIES, true)
        .build();
    this.mapper.setDefaultPropertyInclusion(JsonInclude.Value.construct(
        JsonInclude.Include.NON_NULL,
        JsonInclude.Include.NON_NULL
    ));
    this.mapper.setPropertyNamingStrategy(PropertyNamingStrategies.UPPER_CAMEL_CASE);
    setLiberalMapper();
  }

  public DataHandler(boolean isStrictMapper) {
    this();

    if (isStrictMapper) {
      setStrictMapper();
    } else {
      setLiberalMapper();
    }
  }

  public String toJson(Object data) throws IOException {
    return this.mapper.writerWithDefaultPrettyPrinter().writeValueAsString(data);
  }

  /**
   *
   * @param response  JSON object in String format
   * @param valueType accepts types like ArrayList
   * @param <T>       Class type to return
   * @return requested object type
   * @throws IOException in case converting String to Object fails
   */
  public <T> T fromJson(String response, Class<T> valueType) throws IOException {
    return this.mapper.readValue(response, valueType);
  }

  /**
   *
   * @param response  JSON object in String format
   * @param valueType accepts parametrized types
   * @param <T>       Class type to return
   * @return String object converted to requested object
   * @throws IOException in case converting String to Object fails
   */
  public <T> T fromJson(String response, TypeReference<T> valueType) throws IOException {
    return this.mapper.readValue(response, valueType);
  }

  /**
   * Sets data mapper to be strict when making conversion of data to objects.
   * If there is a mismatch between object and String in any other case than letter case,
   * exception will be thrown.
   */
  public void setStrictMapper() {
    this.mapper.configure(DeserializationFeature.FAIL_ON_IGNORED_PROPERTIES, true);
    this.mapper.configure(DeserializationFeature.FAIL_ON_MISSING_CREATOR_PROPERTIES, true);
    this.mapper.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, true);
  }

  /**
   * Sets data mapper to be very liberal when making conversion of data to objects.
   * Most of the time exception will NOT be thrown.
   */
  public void setLiberalMapper() {
    this.mapper.configure(DeserializationFeature.FAIL_ON_IGNORED_PROPERTIES, false);
    this.mapper.configure(DeserializationFeature.FAIL_ON_MISSING_CREATOR_PROPERTIES, false);
    this.mapper.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false);
  }

}

[elijulian]

I ended up dropping the SDK and just calling their REST API's directly