Skip to content

fix: camera-dependent artifacts (squares / parallel lines) in Area Detector live view — Sector 4 #98

Description

@Osayi-ANL

Issue

Sector 4 specific — reproduced at Sector 4 with specific detector/camera configurations. Not yet tested in post-processing workbench.

The Area Detector live view displays visual artifacts that vary by camera. Two known forms:

  1. Squares — blocky rectangular artifacts tiled across the image
  2. Parallel lines — horizontal or vertical banding overlaid on the data

The artifacts appear to be an artifact of how the raw PVA frame is reshaped into a 2D image — the pixel ordering (C vs Fortran) or shape assumptions may not match the actual camera output layout.

Files:

  • src/dashpva/utils/pva_reader.py:411image.reshape(self.shape, order=self.pixel_ordering) — if pixel_ordering doesn't match the camera's actual row layout, the entire frame is misinterpreted, producing tile or banding patterns
  • src/dashpva/viewer/area_det/area_det_viewer.py:1555np.transpose / np.rot90 applied after reshape; a non-contiguous array at this point could compound the artifact

Fixes

  • src/dashpva/utils/pva_reader.py:411 — investigate whether Sector 4 cameras require a different pixel_ordering; add np.ascontiguousarray() after reshape to eliminate stride-based rendering issues
  • Cross-check the camera's reported dims attribute against the assumed self.shape to catch shape mismatches before they reach setImage

Acceptance Criteria

  • Connect to a Sector 4 camera that previously showed square artifacts in live view — image renders cleanly with no tiling
  • Connect to a Sector 4 camera that previously showed parallel line artifacts — image renders cleanly
  • Other cameras/detectors at other sectors are unaffected

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions