[BUG]: Private mirrors require public DNS

[jonathanspw]

Is there an existing issue for this?

• I have searched the existing issues

Current Behavior

The mirror system requires a public DNS record to exist even for private mirrors. We don't actually check functionality of the mirror when it is set to private only, so there's no reason for us to require DNS records either.

Expected Behavior

Private mirrors should not require DNS records in order to be served by the mirror system.

Steps To Reproduce

No response

Anything else?

No response

Search terms

private mirror dns local ip

[doctatortot]

I’ve been testing this on my end and confirmed the root cause:

the CI scripts always try to run DNS/availability checks, even if a mirror is marked private: true. That makes private mirrors without public DNS blow up validation.

A quick fix is to skip availability checks for private mirrors. Something like this inside are_mirrors_available() works cleanly:

for mirror in mirrors:
    # Skip availability checks for private mirrors
    if getattr(mirror, "private", False):
        logger.info('Skipping availability check for private mirror "%s"', mirror.name)
        continue

    is_available = await mirror_available(
        mirror_info=mirror,
        http_session=http_session,
        logger=logger,
        main_config=main_config,
    )
    ret_code += int(not is_available)

That way, public mirrors are still fully validated, but private mirrors pass without DNS resolution.

I tried patching it locally but ran into repo layout/versioning quirks, so I’ll leave the proper integration to someone more familiar with the codebase. Hopefully this helps point in the right direction.