Skip to content

Test for "bad shutdown" in integration tests #112

Description

@ljwoods2

Is your feature request related to a problem?

Related to #111

While IMDClient must have a timeout on blocking socket reads to prevent excessively long tailing-waits in analysis scripts, the timeout should be practically used as little as possible. In ensemble simulations, relying on a timeout to evaluate when the simulation has ended can effectively wipe out speed-related performance gains from using streaming since it adds a fixed time cost to each simulation (for low output frequency, potentially >5 seconds per simulation)

Describe the solution you'd like

Integration tests should test that the socket read failed because of a closed socket rather than a timeout on a blocked read- this ensures the simulation shut down properly at least in principle (though edge cases for simulation engine shutdown likely exist)

Additional context

Thanks to @jpkrowe for pointing this out- this test would ensure his WESTPA integration performs optimally

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions