Code quality

Author: PeterSurda

.devcontainer/devcontainer.json

@@ -17,7 +17,11 @@
                 "visualstudioexptteam.vscodeintellicode"
             ],
             "settings": {
+                "python.defaultInterpreterPath": "/usr/bin/python3",
+                "flake8.interpreter": ["/usr/bin/python3"],
+                "flake8.importStrategy": "fromEnvironment",
                 "flake8.args": ["--config=setup.cfg"],
+                "pylint.interpreter": ["/usr/bin/python3"],
                 "pylint.args": ["--rcfile=setup.cfg", "--init-hook", "import sys;sys.path.append('src')"],
                 "terminal.integrated.shell.linux": "/usr/bin/zsh",
                 "terminal.integrated.defaultProfile.linux": "zsh",

.devcontainer/postCreateCommand.sh

@@ -1,4 +1,9 @@
 #!/bin/sh
 
 pip3 install -r requirements.txt
-pip3 install -r kivy-requirements.txt
+pip3 install -r kivy-requirements.txt
+
+# Linter tools needed by the VS Code extensions (ms-python.flake8,
+# ms-python.pylint, nwgh.bandit).  The apt-installed system packages
+# are not visible to the VS Code Python interpreter.
+pip3 install flake8 pylint bandit

setup.cfg

@@ -15,18 +15,35 @@ ignore = E722,F841,W503
 # F841: pylint is preferred for unused-variable
 # W503: deprecated: https://bugs.python.org/issue26763 - https://www.python.org/dev/peps/pep-0008/#should-a-line-break-before-or-after-a-binary-operator
 
-# pylint honours the [MESSAGES CONTROL] section
-# as well as [MASTER] section
-[MESSAGES CONTROL]
-disable=
-    invalid-name,bare-except,broad-except,superfluous-parens,
-    bad-option-value
+# -- pylint (modern, >= 2.14) -- pylint.*-prefixed sections for setup.cfg
+
+[pylint.main]
+init-hook = import sys;sys.path.append('src')
+ignore = bitmessagekivy
+
+[pylint.messages_control]
+disable =
+    invalid-name,bare-except,broad-except,relative-import,
+    superfluous-parens,bad-option-value
 # invalid-name: needs fixing during a large, project-wide refactor
 # bare-except,broad-except: Need fixing once thorough testing is easier
 # bad-option-value is for backward compatibility between python 2 and 3
+
+[pylint.design]
 max-args = 8
 max-attributes = 8
 
+# -- pylint (legacy, < 2.0 / python 2.7) -- old .pylintrc-style section names
+
 [MASTER]
 init-hook = import sys;sys.path.append('src')
 ignore = bitmessagekivy
+
+[MESSAGES CONTROL]
+disable =
+    invalid-name,bare-except,broad-except,relative-import,
+    superfluous-parens,bad-option-value
+
+[DESIGN]
+max-args = 8
+max-attributes = 8

src/api.py

@@ -57,7 +57,7 @@
 For further examples please reference `.tests.test_api`.
 """
 
-# pylint: disable=too-many-lines,relative-import
+# pylint: disable=too-many-lines
 
 import base64
 import errno

src/bitmessagecli.py

@@ -2,7 +2,7 @@
 # -*- coding: utf-8 -*-
 # pylint: disable=too-many-lines,global-statement,too-many-branches,too-many-statements,inconsistent-return-statements
 # pylint: disable=too-many-nested-blocks,too-many-locals,protected-access,too-many-arguments,too-many-function-args
-# pylint: disable=no-member
+# pylint: disable=no-member,superfluous-parens
 """
 Created by Adam Melton (.dok) referenceing https://bitmessage.org/wiki/API_Reference for API documentation
 Distributed under the MIT/X11 software license. See http://www.opensource.org/licenses/mit-license.php.
@@ -16,15 +16,14 @@
 import datetime
 import imghdr
 import json
-import ntpath
 import os
 import socket
 import sys
 import time
-
 from six.moves import input as raw_input
 from six.moves import xmlrpc_client as xmlrpclib
 
+import ntpath
 from bmconfigparser import config
 
 

src/bitmessagemain.py

@@ -11,7 +11,7 @@
 # yet contain logic to expand into further streams.
 
 # flake8: noqa:402
-# pylint: disable=superfluous-parens,relative-import
+# pylint: disable=superfluous-parens
 import os
 import sys
 
@@ -212,7 +212,7 @@ def start(self):
 
             # API is also objproc dependent
             if config.safeGetBoolean('bitmessagesettings', 'apienabled'):
-                import api  # pylint: disable=relative-import
+                import api
                 singleAPIThread = api.singleAPI()
                 # close the main program even if there are threads left
                 singleAPIThread.daemon = True
@@ -256,14 +256,13 @@ def start(self):
             while state.shutdown == 0:
                 time.sleep(1)
                 if (
-                    state.testmode
-                    and time.time() - state.last_api_response >= 30
+                        state.testmode
+                        and time.time() - state.last_api_response >= 30
                 ):
                     self.stop()
         elif not state.enableGUI:
             state.enableGUI = True
             try:
-                # pylint: disable=relative-import
                 from tests import core as test_core
             except ImportError:
                 try:

src/bitmessageqt/__init__.py

@@ -1,7 +1,7 @@
 """
 PyQt based UI for bitmessage, the main module
 """
-# pylint: disable=import-error,relative-import,too-many-lines
+# pylint: disable=import-error,too-many-lines
 import hashlib
 import locale
 import os

src/bitmessageqt/address_dialogs.py

@@ -2,7 +2,7 @@
 Dialogs that work with BM address.
 """
 # pylint: disable=attribute-defined-outside-init,too-few-public-methods
-# pylint: disable=relative-import,import-error
+# pylint: disable=import-error
 
 import hashlib
 

src/bitmessageqt/addressvalidator.py

@@ -2,7 +2,7 @@
 Address validator module.
 """
 # pylint: disable=too-many-branches,too-many-arguments
-# pylint: disable=import-error,relative-import
+# pylint: disable=import-error
 
 from Queue import Empty
 

src/bitmessageqt/newchandialog.py

@@ -3,7 +3,7 @@
 =================================
 
 """
-# pylint: disable=import-error,relative-import,ungrouped-imports
+# pylint: disable=import-error,ungrouped-imports
 from PyQt4 import QtCore, QtGui
 
 import widgets