Code quality

Author: PeterSurda

src/depends.py

@@ -188,7 +188,7 @@ def try_import(module, log_extra=False):
             logger.error(
                 'On %s, try running "%s %s" as root.',
                 dist, PACKAGE_MANAGER[dist], PACKAGES[module][dist])
-        return False
+        return None
 
 
 def check_ripemd160():
@@ -274,7 +274,8 @@ def check_openssl():
     if sys.platform == 'win32':
         paths = ['libeay32.dll']
         if getattr(sys, 'frozen', False):
-            paths.insert(0, os.path.join(sys._MEIPASS, 'libeay32.dll'))
+            # pylint: disable=no-member
+            paths.insert(0, os.path.join(sys._MEIPASS, 'libeay32.dll')) 
     else:
         paths = ['libcrypto.so', 'libcrypto.so.1.0.0']
     if sys.platform == 'darwin':

src/fallback/umsgpack/umsgpack.py

@@ -410,8 +410,6 @@ def _pack2(obj, fp, **options):
     >>> umsgpack.pack({u"compact": True, u"schema": 0}, f)
     >>>
     """
-    global compatibility
-
     ext_handlers = options.get("ext_handlers")
 
     if obj is None:
@@ -480,8 +478,6 @@ def _pack3(obj, fp, **options):
     >>> umsgpack.pack({u"compact": True, u"schema": 0}, f)
     >>>
     """
-    global compatibility
-
     ext_handlers = options.get("ext_handlers")
 
     if obj is None:
@@ -665,7 +661,6 @@ def _unpack_string(code, fp, options):
         raise Exception("logic error, not string: 0x%02x" % ord(code))
 
     # Always return raw bytes in compatibility mode
-    global compatibility
     if compatibility:
         return _read_except(fp, length)
 

src/network/bmproto.py

@@ -67,6 +67,14 @@ def __init__(self, address=None, sock=None):
         # track port check requests, only allow one per connection
         # completely disable port checks for now
         self.portCheckRequested = True
+        self.payloadOffset = 0
+        self.invalid = False
+        self.timeOffset = 0
+        self.verackSent = False
+        self.payload = None
+        self.isSSL = False
+        self.remoteProtocolVersion = 0
+        self.nonce = 0
 
     def bm_proto_reset(self):
         """Reset the bitmessage object parser"""

src/shared.py

@@ -15,7 +15,7 @@
 import sys
 from binascii import hexlify
 
-from six.moves.reprlib import repr  # pylint: disable=redefined-builtin
+from six.moves.reprlib import repr  # pylint: disable=redefined-builtin,import-error
 
 # Project imports.
 import highlevelcrypto

tests-kivy.py

@@ -22,7 +22,7 @@ def unittest_discover():
     if in_docker:
         try:
             os.mkdir("../out")
-        except FileExistsError:  # noqa:F821
+        except FileExistsError:  # noqa:F821 pylint: disable=undefined-variable
             pass
 
         ffmpeg = subprocess.Popen([  # pylint: disable=consider-using-with
@@ -38,7 +38,7 @@ def unittest_discover():
     if in_docker:
         ffmpeg.terminate()
         try:
-            ffmpeg.wait(10)
-        except subprocess.TimeoutExpired:
+            ffmpeg.wait(10)  # pylint: disable=too-many-function-args
+        except subprocess.TimeoutExpired:  # pylint: disable=no-member
             ffmpeg.kill()
     sys.exit(not result.wasSuccessful())