Remove partially_met status from criteria — criteria are now binary (met/not_met)

The partially_met status was ambiguous across all categories. Criteria should be
either met or not met; incremental progress is tracked separately by progress criteria.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: xrendan

app/models/commitment.rb

@@ -65,13 +65,13 @@ def derive_status_from_criteria!
 
     if success.all?(&:met?)
       update!(status: :implemented)
-    elsif success.any? { |c| c.met? || c.partially_met? }
-      if execution.any? { |c| c.met? || c.partially_met? }
+    elsif success.any?(&:met?)
+      if execution.any?(&:met?)
         update!(status: :partially_implemented)
       else
         update!(status: :in_progress)
       end
-    elsif execution.any? { |c| c.met? || c.partially_met? }
+    elsif execution.any?(&:met?)
       update!(status: :in_progress)
     end
   end

app/models/criterion.rb

@@ -13,7 +13,6 @@ class Criterion < ApplicationRecord
   enum :status, {
     not_assessed: 0,
     met: 1,
-    partially_met: 2,
     not_met: 3,
     no_longer_applicable: 4
   }

app/models/criterion_assessor.rb

@@ -10,7 +10,7 @@ class CriterionAssessor < Chat
     name "CriterionAssessor"
     description "Assesses a criterion against matched evidence"
     field :assessment, :object, properties: {
-      "new_status" => { type: "string", enum: %w[not_assessed met partially_met not_met no_longer_applicable] },
+      "new_status" => { type: "string", enum: %w[not_assessed met not_met no_longer_applicable] },
       "evidence_notes" => { type: "string", description: "Explanation referencing specific evidence" },
       "confidence" => { type: "number", description: "0.0 to 1.0" }
     }
@@ -41,11 +41,13 @@ def prompt(criterion, evidence_items)
 
     ASSESSMENT RULES:
     - met: Clear evidence that this criterion is fully satisfied
-    - partially_met: Some evidence of progress but not complete
-    - not_met: Evidence exists but shows criterion is not satisfied, or contradictory evidence
+    - not_met: Criterion is not satisfied, even if there is some progress toward it
     - not_assessed: Insufficient evidence to make any determination
     - no_longer_applicable: The commitment has been abandoned or the criterion is moot
 
+    There is NO "partially met" status. Criteria are binary: met or not_met.
+    Progress toward meeting a criterion does not make it met — that is tracked separately by progress criteria.
+
     Be CONSERVATIVE. Only mark as "met" if evidence clearly supports it.
     If current status is already "met" and no contradictory evidence, keep it "met".
     Reference specific evidence items in your evidence_notes.

db/migrate/20260310000004_fix_completion_criteria_partially_met.rb

@@ -0,0 +1,11 @@
+class FixCompletionCriteriaPartiallyMet < ActiveRecord::Migration[8.0]
+  def up
+    Criterion.where(category: :completion, status: :partially_met).find_each do |criterion|
+      criterion.update!(status: :not_met)
+    end
+  end
+
+  def down
+    # Cannot determine which were originally partially_met
+  end
+end

db/migrate/20260310000005_remove_partially_met_status.rb

@@ -0,0 +1,12 @@
+class RemovePartiallyMetStatus < ActiveRecord::Migration[8.0]
+  def up
+    # Convert any remaining partially_met criteria (integer value 2) to not_met (integer value 3)
+    execute <<~SQL
+      UPDATE criteria SET status = 3 WHERE status = 2
+    SQL
+  end
+
+  def down
+    # Cannot restore original partially_met statuses
+  end
+end