Log: based: Don't log specially for PCMK__XA_CIB_UPDATE

As discussed in several recent commit messages, PCMK__XA_CIB_UPDATE used
to get set when broadcasting changes while in legacy mode. We haven't
supported that since 3.0.0, so PCMK__XA_CIB_UPDATE is set only for sync
requests (in sync_our_cib()).

I don't see any reason to treat the return code differently for sync
operations than for other modifying operations.

Signed-off-by: Reid Wahl <nrwahl@protonmail.com>

Author: nrwahl2

daemons/based/based_callbacks.c

@@ -736,21 +736,6 @@ log_op_result(const xmlNode *request, const cib__operation_t *operation, int rc,
     if (!pcmk__is_set(operation->flags, cib__op_attr_modifies)) {
         level = LOG_TRACE;
 
-    } else if (pcmk__xe_attr_is_true(request, PCMK__XA_CIB_UPDATE)) {
-        switch (rc) {
-            case pcmk_rc_ok:
-                level = LOG_INFO;
-                break;
-
-            case pcmk_rc_old_data:
-            case pcmk_rc_diff_failed:
-                level = LOG_TRACE;
-                break;
-
-            default:
-                level = LOG_ERR;
-        }
-
     } else if (rc != pcmk_rc_ok) {
         level = LOG_WARNING;
     }