Skip to content

docs/CI.md lists Lighthouse as non-blocking ("Warn"), contradicting lighthouserc.json and docs/performance/LIGHTHOUSE.md #1692

Description

@1nonlypiece

docs/CI.md's workflow summary table (line 11) lists the Lighthouse workflow's "Blocking?" column as Warn. In reality, lighthouserc.json's assert.assertions configures categories:accessibility, categories:best-practices, and categories:seo as "error" (which Lighthouse CI treats as build-failing) and only categories:performance plus the Core Web Vitals metrics as "warn" — matching docs/performance/LIGHTHOUSE.md's own table one directory over, which correctly states "Accessibility | ≥ 90 | error (blocks merge)", "Best Practices | ... | error (blocks merge)", "SEO | ... | error (blocks merge)". A contributor reading only docs/CI.md's summary table would incorrectly conclude a Lighthouse accessibility regression can't block their PR, when three of its four categories actually can. Acceptance criteria: update docs/CI.md's table to reflect the real per-category blocking behavior (e.g. "Mixed — a11y/best-practices/SEO block, performance warns") instead of a single blanket "Warn".

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions