Crash on incorrect recipe

[Niikelion]

Issue type:

• 🐛 Bug

---

Short description:

Selecting incorrect recipe for Stone Cutter crashes the game and effectively locks the save.

Steps to reproduce the problem:

Place down Stone Cutter. Attach Crafting Interface to it. Insert variable card with crafting recipe stone -> stone bricks. Order crafting of stone bricks.

Expected behaviour:

Maybe some error is reported, but like Crafting Table and Brewing Stand game does not crash.

---

Versions:

• This mod: 1.1.13
• Minecraft: 1.21.11
• Mod loader version: Neoforge 21.11.24

Log file:

Only this part is relevant:

java.lang.IllegalArgumentException: Can only craft in a grid with 1 item, while got5
        at TRANSFORMER/integratedcrafting@1.1.13/org.cyclops.integratedcrafting.core.crafting.processoverride.CraftingProcessOverrideStonecutter.craft(CraftingProcessOverrideStonecutter.java:41) ~[integratedcrafting-1.21.11-neoforge-1.1.13-459.jar:?] {}
        at TRANSFORMER/integratedcrafting@1.1.13/org.cyclops.integratedcrafting.core.CraftingJobHandler.insertCrafting(CraftingJobHandler.java:519) ~[integratedcrafting-1.21.11-neoforge-1.1.13-459.jar:?] {}
        at TRANSFORMER/integratedcrafting@1.1.13/org.cyclops.integratedcrafting.core.CraftingJobHandler.update(CraftingJobHandler.java:448) ~[integratedcrafting-1.21.11-neoforge-1.1.13-459.jar:?] {}
        at TRANSFORMER/integratedcrafting@1.1.13/org.cyclops.integratedcrafting.core.part.PartTypeInterfaceCraftingBase.update(PartTypeInterfaceCraftingBase.java:157) ~[integratedcrafting-1.21.11-neoforge-1.1.13-459.jar:?] {}
        at TRANSFORMER/integratedcrafting@1.1.13/org.cyclops.integratedcrafting.part.PartTypeInterfaceCrafting.update(PartTypeInterfaceCrafting.java:136) ~[integratedcrafting-1.21.11-neoforge-1.1.13-459.jar:?] {}
        at TRANSFORMER/integratedcrafting@1.1.13/org.cyclops.integratedcrafting.part.PartTypeInterfaceCrafting.update(PartTypeInterfaceCrafting.java:61) ~[integratedcrafting-1.21.11-neoforge-1.1.13-459.jar:?] {}
        at TRANSFORMER/integrateddynamics@1.24.1/org.cyclops.integrateddynamics.core.network.PartNetworkElement.update(PartNetworkElement.java:173) ~[integrateddynamics-1.21.11-neoforge-1.24.1-1492.jar:?] {}
        at TRANSFORMER/integrateddynamics@1.24.1/org.cyclops.integrateddynamics.core.network.Network.update(Network.java:395) ~[integrateddynamics-1.21.11-neoforge-1.24.1-1492.jar:?] {}
        at TRANSFORMER/integrateddynamics@1.24.1/org.cyclops.integrateddynamics.core.TickHandler.onTick(TickHandler.java:73) ~[integrateddynamics-1.21.11-neoforge-1.24.1-1492.jar:?] {}

[rubensworks]

Thanks for reporting!

[rubensworks]

Are you sure you're using the latest 1.21.11 version of integrated crafting? (build 459)

[Niikelion]

Yes, I updated to it today. I'm working on the pr to fix this issue right now, although it may take some time as this is the first time working on a MC mod.

[Niikelion]

@rubensworks
Will it be ok to catch exceptions invoked in craft from within insertCrafting and return false on exception + log warning/error?

[rubensworks]

It would be better if the exception is just not thrown in the first place. (I don't have the code open atm, so my answer may be inaccurate)

[rubensworks]

Just a try-catch around this is probably fine: https://github.com/CyclopsMC/IntegratedCrafting/blob/master-1.21/src/main/java/org/cyclops/integratedcrafting/core/CraftingJobHandler.java#L519
No need to log a warning.

Would also be good to check if this occurs for older MC versions, and if so, implement this in the oldest MC version (in can upmerge when I release).

GitHub

IntegratedCrafting/src/main/java/org/cyclops/integratedcrafting/core/CraftingJobHandler.java at master-1.21 · CyclopsMC/IntegratedCrafting

Craft stuff in Integrated Dynamics networks. Contribute to CyclopsMC/IntegratedCrafting development by creating an account on GitHub.

[Niikelion]

I agree, that probably the exceptions should not be thrown from within the overrides. I can take some time to create a proposal for this(comunicating to the user, that the recipe is incorrect in other way than exception), but I'm kinda hoping that this small fix can be merged before that. This bug kinda messed up mine and my wife server and I was hoping to get it up and running 😀

[Niikelion]

I can confirm, that this is also the case for 1.20-lts

[rubensworks]

Thanks for checking.
In that case I won't merge #179, but instead target it for 1.20-lts, and upmerge it manually upon release.