Truncate embed fields in guild_info

Author: GnomedDev

tts_commands/src/owner.rs

@@ -15,7 +15,7 @@ use self::serenity::{
 use poise::{serenity_prelude as serenity, CreateReply};
 
 use tts_core::{
-    common::dm_generic,
+    common::{dm_generic, safe_truncate},
     database,
     database_models::Compact,
     structs::{Command, CommandResult, Context, PrefixContext, TTSModeChoice},
@@ -342,7 +342,7 @@ fn process_cache_info(
     Some(fields)
 }
 
-#[poise::command(prefix_command, owners_only)]
+#[poise::command(prefix_command, owners_only, hide_in_help)]
 pub async fn cache_info(ctx: Context<'_>, kind: Option<String>) -> CommandResult {
     ctx.defer().await?;
 
@@ -394,8 +394,12 @@ fn format_channels<'a>(channels: impl Iterator<Item = &'a serenity::GuildChannel
     let mut out = String::new();
     for channel in channels {
         writeln!(out, "`{}`: {}", channel.id, channel.base.name).unwrap();
+        if out.len() >= 1024 {
+            break;
+        }
     }
 
+    safe_truncate(&mut out, 1024);
     out
 }
 
@@ -406,7 +410,7 @@ fn get_runner_channel(
     ctx.runners.get(&shard_id).map(|entry| entry.1.clone())
 }
 
-#[poise::command(prefix_command, owners_only)]
+#[poise::command(prefix_command, owners_only, hide_in_help)]
 pub async fn guild_info(ctx: Context<'_>, guild_id: Option<serenity::GuildId>) -> CommandResult {
     let cache = ctx.cache();
     let Some(guild_id) = guild_id.or(ctx.guild_id()) else {
@@ -423,7 +427,7 @@ pub async fn guild_info(ctx: Context<'_>, guild_id: Option<serenity::GuildId>) -
         .footer(CreateEmbedFooter::new(&*footer))
         .title(&*title);
 
-    let permissions_formatted;
+    let mut permissions_formatted;
     let mut guild_cached = false;
     if let Some(guild) = cache.guild(guild_id) {
         guild_cached = true;
@@ -433,6 +437,7 @@ pub async fn guild_info(ctx: Context<'_>, guild_id: Option<serenity::GuildId>) -
                 "Administrator"
             } else {
                 permissions_formatted = permissions.to_string();
+                safe_truncate(&mut permissions_formatted, 256);
                 &permissions_formatted
             };
 

tts_core/src/common.rs

@@ -438,3 +438,18 @@ pub async fn confirm_dialog(
 
     confirm_dialog_wait(ctx.serenity_context(), message.id, ctx.author().id).await
 }
+
+/// Avoid char boundary panics with utf8 chars
+pub fn safe_truncate(string: &mut String, mut new_len: usize) {
+    if string.len() <= new_len {
+        return;
+    }
+
+    new_len -= 3;
+    while !string.is_char_boundary(new_len) {
+        new_len -= 1;
+    }
+
+    string.truncate(new_len);
+    string.push_str("...");
+}

tts_core/src/errors.rs

@@ -12,7 +12,7 @@ use self::serenity::{
 use poise::serenity_prelude as serenity;
 
 use crate::{
-    common::push_permission_names,
+    common::{push_permission_names, safe_truncate},
     constants,
     opt_ext::OptionTryUnwrap,
     structs::{Context, Data},
@@ -42,19 +42,6 @@ fn hash(data: &[u8]) -> Vec<u8> {
     Vec::from(&*hasher.finalize())
 }
 
-fn truncate_error(error: &Error) -> String {
-    let mut long_err = error.to_string();
-
-    // Avoid char boundary panics with utf8 chars
-    let mut new_len = 256;
-    while !long_err.is_char_boundary(new_len) {
-        new_len -= 1;
-    }
-
-    long_err.truncate(new_len);
-    long_err
-}
-
 pub async fn handle_unexpected<'a>(
     ctx: &serenity::Context,
     event: &'a str,
@@ -112,8 +99,12 @@ pub async fn handle_unexpected<'a>(
     ];
 
     let mut embed = serenity::CreateEmbed::default()
-        .title(truncate_error(&error))
-        .colour(constants::RED);
+        .colour(constants::RED)
+        .title({
+            let mut error_str = error.to_string();
+            safe_truncate(&mut error_str, 256);
+            error_str
+        });
 
     for (title, mut value, inline) in before_fields
         .into_iter()