Skip to content

[SC-71] contrib's coverage floor (35%) lags far behind the other three enforced crates #1342

Description

@yusuftomilola

Overview

contracts/scripts/check-coverage.sh sets per-crate floors of assetsup: 70, contrib: 35, multisig-wallet: 90, asset-maintenance: 70 — contrib sits meaningfully lower than every other enforced crate. Once [SC-57] resolves the uncompiled-file question (which changes what "100% of contrib" even means) and [SC-70] adds insurance/lease coverage, the crate's real coverage should be re-measured and the floor ratcheted up to be in line with its siblings, per the script's own stated policy ("Ratchet these upward as coverage improves; never lower one without saying why").

Tasks

  • After [SC-57] and [SC-70] land, re-run cargo llvm-cov for contrib and raise crate_floor()'s contrib case to just below the newly-measured value, matching the pattern used for the other three crates.
  • Update the "Measured at time of writing" comment block with the new number.

Acceptance Criteria

  • contrib's coverage floor is back in line with the workspace's other enforced crates, with an accurate "measured at" comment.

Dependencies

Depends on [SC-57] and [SC-70].

Notes for Contributors

Requires Rust + Soroban. Workspace: contracts/ (soroban-sdk 23, members: assetsup, contrib, multisig-wallet, multisig-transfer, asset-maintenance). Run cargo test --all, cargo fmt --all -- --check, and cargo clippy --all-targets --all-features -- -D warnings before opening a PR — CI enforces all three. Comment below to be assigned.

Metadata

Metadata

Assignees

No one assigned

    Labels

    contracttestingTests, QA, and quality assurance

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions