[SC-78] assetsup's paired old/new test files need a duplication audit

[yusuftomilola]

Overview

contracts/assetsup/src/tests/ has both an original and a _new suffixed file for several areas — insurance.rs + insurance_new.rs, tokenization.rs + tokenization_new.rs, plus standalone dividends_new.rs, voting_new.rs, transfer_restrictions_new.rs, and detokenization_new.rs with no non-_new counterpart. This naming pattern strongly suggests a module was re-implemented in a later pass without the older test file being reconciled or removed, which risks either duplicate coverage (wasted CI time) or, worse, the old file silently testing stale/removed behavior.

Tasks

• For each X.rs/X_new.rs pair, diff them: if X_new.rs supersedes X.rs, remove X.rs (or merge any test case it has that X_new.rs is missing) and drop the _new suffix for clarity.
• For the standalone _new-suffixed files with no pair, just drop the suffix if there's no naming collision reason for it to still be there.

Acceptance Criteria

• No test file in assetsup/src/tests/ carries a _new suffix implying an un-reconciled duplicate, and no coverage was silently testing removed behavior.

Notes for Contributors

Requires Rust + Soroban. Workspace: contracts/ (soroban-sdk 23, members: assetsup, contrib, multisig-wallet, multisig-transfer, asset-maintenance). Run cargo test --all, cargo fmt --all -- --check, and cargo clippy --all-targets --all-features -- -D warnings before opening a PR — CI enforces all three. Comment below to be assigned.

[cyberdocs120]

@cyberdocs120 has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

I’d like to work on this issue because it addresses an important area of the project and presents a great opportunity to make a meaningful contribution. I’m particularly interested in delivering a solution that is reliable, maintainable, and aligned with the project’s existing architecture and development standards.

I have experience working across software development, including backend and frontend development, APIs, databases, testing, DevOps, and blockchain-based applications. I’m comfortable understanding existing codebases, identifying the root cause of issues, implementing clean and scalable solutions, and writing thorough tests to prevent regressions.

My approach would be to first understand the existing implementation and project conventions, then develop the solution in a focused and incremental way. I’ll ensure the changes are well-tested, documented where necessary, and do not introduce unnecessary complexity or break existing functionality. I’m also committed to clear communication, responding to review feedback, and delivering a polished contribution that provides real value to the project.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @cyberdocs120 to this issue.

[samkay-ops]

@samkay-ops has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

Hi team,
I'm applying to work on this issue.
I have strong experience with TypeScript, NestJS, and Soroban smart contracts. I will deliver clean, tested code following the acceptance criteria.
Ready to start immediately.
Best regards,
samkay-ops

ℹ️ Repo Maintainers: To accept this application, review their application or assign @samkay-ops to this issue.

[Tosme005]

@Tosme005 has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

Hello, I reviewed the issue requirements and have tackled similar implementations in the past. I’d love to take ownership of this to deliver a clean, well-tested solution. Please consider assigning it to me

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Tosme005 to this issue.

[NeduTheDev1]

@NeduTheDev1 has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

Please assign to me maintainer I can handle with ease

ℹ️ Repo Maintainers: To accept this application, review their application or assign @NeduTheDev1 to this issue.

[faithylet]

@faithylet has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

I’d like to work on this issue. I’ll audit the paired old/new test files for duplicated or redundant coverage, identify what can be safely removed or consolidated, and ensure the remaining tests still provide complete coverage without changing expected behavior.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @faithylet to this issue.

[akansmafengadamu]

@akansmafengadamu has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

Hello maintainer
I would love to contribute to this Issue and I assure you the best result which matches your expectation

ℹ️ Repo Maintainers: To accept this application, review their application or assign @akansmafengadamu to this issue.