Skip to content

[SC-79] assetsup's error.rs completeness vs. contrib's error.rs needs a cross-check #1350

Description

@yusuftomilola

Overview

assetsup and contrib maintain separate Error enums (per contrib's own doc comment: "Several module names appear in both... but the implementations have diverged and are not interchangeable") — worth a direct audit that assetsup's error enum has equivalent coverage to what [SC-58]/[SC-59]/[SC-60] are about to require of the other three crates, so this cleanup doesn't leave assetsup as the one crate that was never checked.

Tasks

  • Run the same .unwrap()/.expect() audit already done for multisig-wallet/contrib/asset-maintenance ([SC-58]/[SC-59]/[SC-60]) against assetsup/src/*.rs (excluding tests/) — the earlier repo-wide grep found only 2 hits there, but confirm those 2 are legitimately safe (e.g. genuinely-unreachable Options) rather than another real gap.
  • Document the finding either way so this crate isn't silently skipped while its siblings get fixed.

Acceptance Criteria

  • assetsup's remaining .unwrap()/.expect() call sites (if any) are explicitly reviewed and either justified or fixed, not just assumed fine because the count is low.

Dependencies

Companion audit to [SC-58]/[SC-59]/[SC-60].

Notes for Contributors

Requires Rust + Soroban. Workspace: contracts/ (soroban-sdk 23, members: assetsup, contrib, multisig-wallet, multisig-transfer, asset-maintenance). Run cargo test --all, cargo fmt --all -- --check, and cargo clippy --all-targets --all-features -- -D warnings before opening a PR — CI enforces all three. Comment below to be assigned.

Metadata

Metadata

Assignees

No one assigned

    Labels

    contracttestingTests, QA, and quality assurance

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions