Overview
assetsup and contrib maintain separate Error enums (per contrib's own doc comment: "Several module names appear in both... but the implementations have diverged and are not interchangeable") — worth a direct audit that assetsup's error enum has equivalent coverage to what [SC-58]/[SC-59]/[SC-60] are about to require of the other three crates, so this cleanup doesn't leave assetsup as the one crate that was never checked.
Tasks
Acceptance Criteria
Dependencies
Companion audit to [SC-58]/[SC-59]/[SC-60].
Notes for Contributors
Requires Rust + Soroban. Workspace: contracts/ (soroban-sdk 23, members: assetsup, contrib, multisig-wallet, multisig-transfer, asset-maintenance). Run cargo test --all, cargo fmt --all -- --check, and cargo clippy --all-targets --all-features -- -D warnings before opening a PR — CI enforces all three. Comment below to be assigned.
Overview
assetsupandcontribmaintain separateErrorenums (per contrib's own doc comment: "Several module names appear in both... but the implementations have diverged and are not interchangeable") — worth a direct audit thatassetsup's error enum has equivalent coverage to what [SC-58]/[SC-59]/[SC-60] are about to require of the other three crates, so this cleanup doesn't leaveassetsupas the one crate that was never checked.Tasks
.unwrap()/.expect()audit already done for multisig-wallet/contrib/asset-maintenance ([SC-58]/[SC-59]/[SC-60]) againstassetsup/src/*.rs(excludingtests/) — the earlier repo-wide grep found only 2 hits there, but confirm those 2 are legitimately safe (e.g. genuinely-unreachableOptions) rather than another real gap.Acceptance Criteria
.unwrap()/.expect()call sites (if any) are explicitly reviewed and either justified or fixed, not just assumed fine because the count is low.Dependencies
Companion audit to [SC-58]/[SC-59]/[SC-60].
Notes for Contributors
Requires Rust + Soroban. Workspace:
contracts/(soroban-sdk 23, members: assetsup, contrib, multisig-wallet, multisig-transfer, asset-maintenance). Runcargo test --all,cargo fmt --all -- --check, andcargo clippy --all-targets --all-features -- -D warningsbefore opening a PR — CI enforces all three. Comment below to be assigned.