Make it so concrt140.dll can be included with the browser without breaking dependentlibs.list generation

[the-r3dacted]

This dll is part of VC++, and required to work on old versions of Windows without it. It will show as Lun3r/Hydra silently crashing at launch while roytam1's fork works as it includes the dll. roytam1 works around this issue by manually including the dlls, and I could do this for the portable release, but I can't do this for the installer release.

Currently reverting this commit and building results in this. (Long compile times are because I set 1 job.)

66:00.67 Unified_cpp_mfbt_staticruntime0.cpp
66:00.71 mfbt_staticruntime.lib.desc
66:09.65 dependentlibs.list
66:31.47 Traceback (most recent call last):
66:31.47   File "c:\mozilla-build-3.2\python\Lib\runpy.py", line 174, in _run_module_as_main
66:31.47     "__main__", fname, loader, pkg_name)
66:31.47   File "c:\mozilla-build-3.2\python\Lib\runpy.py", line 72, in _run_code
66:31.47     exec code in run_globals
66:31.47   File "c:\Users\Admin\Documents\GitHub\UXP\python\mozbuild\mozbuild\action\file_generate.py", line 108, in <module>
66:31.47     sys.exit(main(sys.argv[1:]))
66:31.47   File "c:\Users\Admin\Documents\GitHub\UXP\python\mozbuild\mozbuild\action\file_generate.py", line 63, in main
66:31.48     ret = module.__dict__[method](output, *args.additional_arguments)
66:31.48   File "c:/Users/Admin/Documents/GitHub/UXP/toolkit/library/dependentlibs.py", line 150, in gen_list
66:31.48     deps = dependentlibs(lib, libpaths, func)
66:31.48   File "c:/Users/Admin/Documents/GitHub/UXP/toolkit/library/dependentlibs.py", line 125, in dependentlibs
66:31.48     deps.update(dependentlibs(deppath, libpaths, func))
66:31.48   File "c:/Users/Admin/Documents/GitHub/UXP/toolkit/library/dependentlibs.py", line 125, in dependentlibs
66:31.48     deps.update(dependentlibs(deppath, libpaths, func))
66:31.48   File "c:/Users/Admin/Documents/GitHub/UXP/toolkit/library/dependentlibs.py", line 125, in dependentlibs
66:31.48     deps.update(dependentlibs(deppath, libpaths, func))
66:31.48   File "c:/Users/Admin/Documents/GitHub/UXP/toolkit/library/dependentlibs.py", line 125, in dependentlibs
66:31.48     deps.update(dependentlibs(deppath, libpaths, func))
66:31.48   File "c:/Users/Admin/Documents/GitHub/UXP/toolkit/library/dependentlibs.py", line 125, in dependentlibs
66:31.48     deps.update(dependentlibs(deppath, libpaths, func))
66:31.48   File "c:/Users/Admin/Documents/GitHub/UXP/toolkit/library/dependentlibs.py", line 125, in dependentlibs
66:31.48     deps.update(dependentlibs(deppath, libpaths, func))
66:31.48   File "c:/Users/Admin/Documents/GitHub/UXP/toolkit/library/dependentlibs.py", line 125, in dependentlibs
66:31.48     deps.update(dependentlibs(deppath, libpaths, func))
66:31.48   File "c:/Users/Admin/Documents/GitHub/UXP/toolkit/library/dependentlibs.py", line 125, in dependentlibs
66:31.48     deps.update(dependentlibs(deppath, libpaths, func))
66:31.48   File "c:/Users/Admin/Documents/GitHub/UXP/toolkit/library/dependentlibs.py", line 125, in dependentlibs
66:31.48     deps.update(dependentlibs(deppath, libpaths, func))

This continues to repeat for a while.

66:32.40   File "c:/Users/Admin/Documents/GitHub/UXP/toolkit/library/dependentlibs.py", line 125, in dependentlibs
66:32.40     deps.update(dependentlibs(deppath, libpaths, func))
66:32.40   File "c:/Users/Admin/Documents/GitHub/UXP/toolkit/library/dependentlibs.py", line 125, in dependentlibs
66:32.40     deps.update(dependentlibs(deppath, libpaths, func))
66:32.42   File "c:/Users/Admin/Documents/GitHub/UXP/toolkit/library/dependentlibs.py", line 125, in dependentlibs
66:32.42     deps.update(dependentlibs(deppath, libpaths, func))
66:32.42   File "c:/Users/Admin/Documents/GitHub/UXP/toolkit/library/dependentlibs.py", line 125, in dependentlibs
66:32.42     deps.update(dependentlibs(deppath, libpaths, func))
66:32.42   File "c:/Users/Admin/Documents/GitHub/UXP/toolkit/library/dependentlibs.py", line 118, in dependentlibs
66:32.42     deps = OrderedDict()
66:32.42   File "c:\mozilla-build-3.2\python\Lib\collections.py", line 69, in __init__
66:32.42     self.__update(*args, **kwds)
66:32.42   File "c:\Users\Admin\Documents\GitHub\UXP\obj-i686-pc-mingw32\_virtualenv\lib\abc.py", line 151, in __subclasscheck__
66:32.42     if subclass in cls._abc_cache:
66:32.42   File "c:\Users\Admin\Documents\GitHub\UXP\obj-i686-pc-mingw32\_virtualenv\lib\_weakrefset.py", line 75, in __contains__
66:32.42     return wr in self.data
66:32.42 RuntimeError: maximum recursion depth exceeded in cmp
66:32.42 mozmake.EXE[5]: *** [backend.mk:10: dependentlibs.list] Error 1
66:32.42 mozmake.EXE[5]: *** Deleting file 'dependentlibs.list'
66:32.42 mozmake.EXE[4]: *** [c:/Users/Admin/Documents/GitHub/UXP/config/recurse.mk:79: toolkit/library/misc] Error 2
66:32.42 mozmake.EXE[3]: *** [c:/Users/Admin/Documents/GitHub/UXP/config/recurse.mk:33: misc] Error 2
66:32.42 mozmake.EXE[2]: *** [c:/Users/Admin/Documents/GitHub/UXP/config/rules.mk:497: default] Error 2
66:32.42 mozmake.EXE[1]: *** [c:/Users/Admin/Documents/GitHub/UXP/client.mk:413: realbuild] Error 2
66:32.42 mozmake.EXE: *** [client.mk:169: build] Error 2
66:32.47 161 compiler warnings present.

I have no idea why this breaks the build, but I guess it does. In research, I found this, a possible workaround, which would exclude these dlls from dependentlibs.list
https://hg-edge.mozilla.org/releases/mozilla-esr128/rev/8bbb2b1fb243
However adding it here results in no change.

Please help

[the-r3dacted]

Does not work on my machine

[teknixstuff]

but it works on my machine ¯\_(ツ)_/¯

[the-r3dacted]

wtf

[teknixstuff]

bizarre, no clue why that happens.