feat: support Java 17 release target#20
Open
Axionize wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
./gradlew test./gradlew jmhClasses./gradlew examplesClassesBenchmark Notes
I ran a separate Java release-target matrix on two machines to check whether Java 17-targeted bytecode regressed the fixed-path benchmarks when run on newer JVMs.
Result: the Ryzen 9 9950X run did not show a material slowdown from Java 17-targeted bytecode on
OptimalPathBenchmark.latticeInlineFusedCompleted; all release-target comparisons for that benchmark were within overlapping JMH errorintervals.
Notes
-Plattice.javaRelease=<version>.-Plattice.javaToolchain=<version>.