fix: return API error codes as strings

Author: javorosas

CHANGELOG.md

@@ -10,7 +10,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Added
 
 - Add `ApiErrorCodes`, grouped constants for documented API root codes and Facturapi-owned validation detail codes.
-- Add `FacturapiException.getApiErrorCode()` for the string V2 root error code while preserving `getErrorCode()` compatibility.
+- Fix `FacturapiException.getErrorCode()` to return only documented string API root codes.
 
 ## [1.3.0] - 2026-06-07
 

README.es.md

@@ -91,7 +91,7 @@ try {
 } catch (FacturapiException e) {
   System.out.println(e.getMessage());
   System.out.println(e.getStatusCode());
-  if (ApiErrorCodes.RequestErrorCode.RATE_LIMIT_EXCEEDED.equals(e.getApiErrorCode())) {
+  if (ApiErrorCodes.RequestErrorCode.RATE_LIMIT_EXCEEDED.equals(e.getErrorCode())) {
     System.out.println(e.getHeaders().get("retry-after"));
   }
   System.out.println(e.getErrorPath());

README.md

@@ -91,7 +91,7 @@ try {
 } catch (FacturapiException e) {
   System.out.println(e.getMessage());
   System.out.println(e.getStatusCode());
-  if (ApiErrorCodes.RequestErrorCode.RATE_LIMIT_EXCEEDED.equals(e.getApiErrorCode())) {
+  if (ApiErrorCodes.RequestErrorCode.RATE_LIMIT_EXCEEDED.equals(e.getErrorCode())) {
     System.out.println(e.getHeaders().get("retry-after"));
   }
   System.out.println(e.getErrorPath());

src/main/java/io/facturapi/FacturapiException.java

@@ -7,7 +7,7 @@
 
 public class FacturapiException extends RuntimeException {
   private final int statusCode;
-  private final Object errorCode;
+  private final String errorCode;
   private final String errorPath;
   private final String errorLocation;
   private final JsonNode errors;
@@ -29,14 +29,14 @@ public FacturapiException(String message, Throwable cause) {
     this.headers = Collections.emptyMap();
   }
 
-  public FacturapiException(String message, int statusCode, Object errorCode, String errorPath) {
+  public FacturapiException(String message, int statusCode, String errorCode, String errorPath) {
     this(message, statusCode, errorCode, errorPath, null, null, null, Collections.emptyMap());
   }
 
   public FacturapiException(
     String message,
     int statusCode,
-    Object errorCode,
+    String errorCode,
     String errorPath,
     String errorLocation,
     JsonNode errors,
@@ -57,19 +57,10 @@ public int getStatusCode() {
     return statusCode;
   }
 
-  public Object getErrorCode() {
+  public String getErrorCode() {
     return errorCode;
   }
 
-  /**
-   * Returns the documented V2 API root error code when the response contains one.
-   *
-   * <p>{@link #getErrorCode()} remains available for compatibility with older API responses.</p>
-   */
-  public String getApiErrorCode() {
-    return errorCode instanceof String ? (String) errorCode : null;
-  }
-
   public String getErrorPath() {
     return errorPath;
   }

src/main/java/io/facturapi/http/FacturapiHttpClient.java

@@ -210,7 +210,7 @@ private static JsonNode firstDefined(JsonNode node, String... keys) {
   private FacturapiException buildApiException(String bodyText, Response response) {
     int statusCode = response.code();
     int resolvedStatus = statusCode;
-    Object errorCode = null;
+    String errorCode = null;
     String errorPath = null;
     String errorLocation = null;
     JsonNode errors = null;
@@ -245,18 +245,8 @@ private FacturapiException buildApiException(String bodyText, Response response)
           }
 
           JsonNode codeNode = firstDefined(root, "code");
-          if (codeNode != null && !codeNode.isNull()) {
-            if (codeNode.isTextual()) {
-              errorCode = codeNode.asText();
-            } else if (codeNode.isIntegralNumber()) {
-              errorCode = codeNode.intValue();
-            } else if (codeNode.isNumber()) {
-              errorCode = codeNode.numberValue();
-            } else if (codeNode.isBoolean()) {
-              errorCode = codeNode.asBoolean();
-            } else {
-              errorCode = codeNode.toString();
-            }
+          if (codeNode != null && codeNode.isTextual()) {
+            errorCode = codeNode.asText();
           }
 
           JsonNode pathNode = firstDefined(root, "path");

src/test/java/io/facturapi/FacturapiHttpClientTest.java

@@ -2,6 +2,7 @@
 
 import static org.junit.jupiter.api.Assertions.assertArrayEquals;
 import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNull;
 import static org.junit.jupiter.api.Assertions.assertThrows;
 import static org.junit.jupiter.api.Assertions.assertTrue;
 
@@ -71,12 +72,30 @@ void throwsFacturapiExceptionWithApiMessage() {
     assertEquals(400, ex.getStatusCode());
     assertTrue(ex.getMessage().contains("Invalid customer"));
     assertEquals(ApiErrorCodes.RequestErrorCode.INVALID_REQUEST, ex.getErrorCode());
-    assertEquals(ApiErrorCodes.RequestErrorCode.INVALID_REQUEST, ex.getApiErrorCode());
     assertEquals("customer.tax_id", ex.getErrorPath());
     assertEquals("body", ex.getErrorLocation());
     assertEquals("log_123", ex.getLogId());
     assertEquals("required", ex.getErrors().get(0).get("code").asText());
     assertEquals("3", ex.getHeaders().get("Retry-After").get(0));
     assertEquals("log_123", ex.getHeaders().get("x-facturapi-log-id").get(0));
   }
+
+  @Test
+  void ignoresNonStringApiErrorCodes() {
+    StubHttpClient httpClient = new StubHttpClient();
+    httpClient.enqueueJson(400, "{\"message\":\"Invalid customer\",\"code\":400}");
+
+    FacturapiHttpClient client = new FacturapiHttpClient(
+      FacturapiConfig.builder("sk_test_123")
+        .httpClient(httpClient.client())
+        .build()
+    );
+
+    FacturapiException ex = assertThrows(
+      FacturapiException.class,
+      () -> client.get("/customers/cus_1", null, GenericResponse.class)
+    );
+
+    assertNull(ex.getErrorCode());
+  }
 }