refactor: simplify organization uploads

Author: javorosas

README.md

@@ -51,6 +51,24 @@ var invoice = facturapi.invoices().create(Map.of(
 System.out.println(invoice.getId());
 ```
 
+## Uploads
+
+```java
+import java.io.File;
+
+var organization = facturapi.organizations().uploadLogo(
+  "org_123",
+  new File("logo.png")
+);
+
+var updated = facturapi.organizations().uploadCertificate(
+  "org_123",
+  new File("certificate.cer"),
+  new File("certificate.key"),
+  "secret"
+);
+```
+
 ## Design
 
 - Inputs use flexible JSON dictionaries (`Map<String, Object>`).

src/main/java/io/facturapi/resources/OrganizationsResource.java

@@ -90,15 +90,15 @@ public DomainAvailability checkDomainAvailability(Map<String, ?> query) {
    * Uploads organization logo file.
    */
   public Organization uploadLogo(String id, File file) throws IOException {
-    return uploadLogo(id, Files.readAllBytes(file.toPath()), file.getName());
+    return uploadLogo(id, Files.readAllBytes(file.toPath()));
   }
 
   /**
    * Uploads organization logo file bytes.
    */
-  public Organization uploadLogo(String id, byte[] fileBytes, String fileName) {
+  public Organization uploadLogo(String id, byte[] fileBytes) {
     MultipartBody multipartBody = new MultipartBodyBuilder()
-      .addFile("file", fileName, fileBytes, "application/octet-stream")
+      .addFile("file", "logo.jpg", fileBytes, "application/octet-stream")
       .build();
     return client.putMultipart("/organizations/" + id + "/logo", multipartBody, Organization.class);
   }
@@ -110,27 +110,18 @@ public Organization uploadCertificate(String id, File cerFile, File keyFile, Str
     return uploadCertificate(
       id,
       Files.readAllBytes(cerFile.toPath()),
-      cerFile.getName(),
       Files.readAllBytes(keyFile.toPath()),
-      keyFile.getName(),
       password
     );
   }
 
   /**
    * Uploads organization CSD certificate file bytes.
    */
-  public Organization uploadCertificate(
-    String id,
-    byte[] cerFileBytes,
-    String cerFileName,
-    byte[] keyFileBytes,
-    String keyFileName,
-    String password
-  ) {
+  public Organization uploadCertificate(String id, byte[] cerFileBytes, byte[] keyFileBytes, String password) {
     MultipartBody multipartBody = new MultipartBodyBuilder()
-      .addFile("cer", cerFileName, cerFileBytes, "application/octet-stream")
-      .addFile("key", keyFileName, keyFileBytes, "application/octet-stream")
+      .addFile("cer", "certificate.cer", cerFileBytes, "application/octet-stream")
+      .addFile("key", "certificate.key", keyFileBytes, "application/octet-stream")
       .addField("password", password)
       .build();
     return client.putMultipart("/organizations/" + id + "/certificate", multipartBody, Organization.class);

src/test/java/io/facturapi/FacturapiResourcesTest.java

@@ -73,7 +73,7 @@ void organizationUploadsAcceptBytes() {
         .build()
     );
 
-    var response = sdk.organizations().uploadLogo("org_1", "logo-bytes".getBytes(StandardCharsets.UTF_8), "logo.png");
+    var response = sdk.organizations().uploadLogo("org_1", "logo-bytes".getBytes(StandardCharsets.UTF_8));
 
     assertEquals("org_1", response.getId());
     assertEquals("PUT", httpClient.requests().get(0).method());
@@ -94,9 +94,7 @@ void organizationCertificateUploadsAcceptBytes() {
     var response = sdk.organizations().uploadCertificate(
       "org_1",
       "cer-bytes".getBytes(StandardCharsets.UTF_8),
-      "certificate.cer",
       "key-bytes".getBytes(StandardCharsets.UTF_8),
-      "certificate.key",
       "secret"
     );