Skip to content

Links auto-migration quality #157

@tomusdrw

Description

@tomusdrw

The link-check tool offers auto-migration of GP links to their newest versions. However while working on this in Typeberry codebase (FluffyLabs/typeberry#247) I've noticed that:

  1. Some links were reported as "can be migrated", yet they were pointing to a completely different part of the Gray Paper (usually it was just one small part selected or there was no selection at all, so after loading it was just displaying the first page of GP).
  2. Some links were reported as "broken", yet they were completely fine.

I think we should err on the safe side with this one, and we should avoid false positives as much as possible.

I'm wondering if we could:

  1. Find the actual selection and compare it's levensthein distance - at least we would be certain that the text is similar.
  2. Make sure there is any selection at all (that might be a bug in the rendering rather than migration?).
  3. Perhaps reject the link if the latex source is significantly different? (however that should not be happening, since we are only considering latex lines that are similar).

I'm expecting that this might be some hidden bug somewhere in the block-matching. Some examples of broken links:

reported as broken, yet fine (this is potentially fine, since it's a false-negative - better safe than sorry).

  ⚠️  https://graypaper.fluffylabs.dev/#/6e1c0cd/0faf010faf01
    at ../../../typeberry2/packages/transition/recent-history.ts:60
    ☠️  https://graypaper.fluffylabs.dev/#/579bd12/0faf010faf01

Reported as fine, but broken:

     23: 🧹 https://graypaper.fluffylabs.dev/#/364735a/37d10237d102 (version: 0.4.5)
      Can be migrated to (please check!):
      👉 https://graypaper.fluffylabs.dev/#/579bd12/3b09003b0900 (version: 0.5.4)
    78: 🧹 https://graypaper.fluffylabs.dev/#/364735a/30a20030a200 (version: 0.4.5)
      Can be migrated to (please check!):
      👉 https://graypaper.fluffylabs.dev/#/579bd12/306601306601 (version: 0.5.4)
    35: 🧹 https://graypaper.fluffylabs.dev/#/c71229b/082200082400 (version: 0.4.1)
      Can be migrated to (please check!):
      👉 https://graypaper.fluffylabs.dev/#/579bd12/082200081c00 (version: 0.5.4)

     42: 🧹 https://graypaper.fluffylabs.dev/#/c71229b/082200082400 (version: 0.4.1)
      Can be migrated to (please check!):
      👉 https://graypaper.fluffylabs.dev/#/579bd12/082200081c00 (version: 0.5.4)

     49: 🧹 https://graypaper.fluffylabs.dev/#/c71229b/082d00083a00 (version: 0.4.1)
      Can be migrated to (please check!):
      👉 https://graypaper.fluffylabs.dev/#/579bd12/082d00082a00 (version: 0.5.4)

     56: 🧹 https://graypaper.fluffylabs.dev/#/c71229b/081c00082100 (version: 0.4.1)
      Can be migrated to (please check!):
      👉 https://graypaper.fluffylabs.dev/#/579bd12/082100082100 (version: 0.5.4)

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions