Merge pull request #30 from FreeClimbAPI/VCSWP-18905

ngarg-vail · web-flow · commit 344c03121f72 · 2023-02-22T18:43:21.000-05:00
Update OutDial model
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -9,6 +9,14 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
 
 None
 
+<a name="5.1.2"></a>
+
+## [5.1.2] 2023-02-21
+
+### Changed
+
+- OutDial PerCL command callingNumber and destination types fixed
+
 <a name="5.1.1"></a>
 
 ## [5.1.1] 2023-02-14
diff --git a/README.md b/README.md
@@ -40,7 +40,7 @@ Add this dependency to your project's POM:
 <dependency>
   <groupId>com.github.freeclimbapi</groupId>
   <artifactId>freeclimb-java-client</artifactId>
-  <version>5.1.1</version>
+  <version>5.1.2</version>
   <scope>compile</scope>
 </dependency>
 ```
@@ -56,7 +56,7 @@ Add this dependency to your project's build file:
   }
 
   dependencies {
-     implementation "com.github.freeclimbapi:freeclimb-java-client:5.1.1"
+     implementation "com.github.freeclimbapi:freeclimb-java-client:5.1.2"
   }
 ```
 
@@ -70,7 +70,7 @@ mvn clean package
 
 Then manually install the following JARs:
 
-* `target/freeclimb-java-client-5.1.1.jar`
+* `target/freeclimb-java-client-5.1.2.jar`
 * `target/lib/*.jar`
 
 ## Getting Started
diff --git a/build.gradle b/build.gradle
@@ -4,7 +4,7 @@ apply plugin: 'java'
 apply plugin: 'com.diffplug.spotless'
 
 group = 'com.github.freeclimbapi'
-version = '5.1.1'
+version = '5.1.2'
 
 buildscript {
     repositories {
diff --git a/build.sbt b/build.sbt
@@ -2,7 +2,7 @@ lazy val root = (project in file(".")).
   settings(
     organization := "com.github.freeclimbapi",
     name := "freeclimb-java-client",
-    version := "5.1.1",
+    version := "5.1.2",
     scalaVersion := "2.11.4",
     scalacOptions ++= Seq("-feature"),
     javacOptions in compile ++= Seq("-Xlint:deprecation"),
diff --git a/docs/OutDial.md b/docs/OutDial.md
@@ -10,8 +10,8 @@ Name | Type | Description | Notes
 ------------ | ------------- | ------------- | -------------
 **actionUrl** | **String** | URL to which FreeClimb sends an HTTP POST request.  | 
 **callConnectUrl** | **String** | URL to which FreeClimb makes an HTTP POST request informing the result of the OutDial. | 
-**callingNumber** | **BigDecimal** | he caller ID to show to the called party when FreeClimb calls. This can be one of the following: The To or From number provided in the first Webhook to your webserver. Any phone number you have purchased from FreeClimb. | 
-**destination** | **BigDecimal** | E.164 representation of the phone number to Call.  | 
+**callingNumber** | **String** | he caller ID to show to the called party when FreeClimb calls. This can be one of the following: The To or From number provided in the first Webhook to your webserver. Any phone number you have purchased from FreeClimb. | 
+**destination** | **String** | E.164 representation of the phone number to Call.  | 
 **ifMachine** | **IfMachine** |  |  [optional]
 **ifMachineUrl** | **String** | When the &#x60;ifMachine&#x60; flag is set to &#x60;redirect&#x60;, this attribute specifies a URL to which FreeClimb makes a POST request when an answering machine or a fax machine is detected. This URL is required if the &#x60;ifMachine&#x60; flag is set to &#x60;redirect&#x60;. Otherwise, it should not be included. |  [optional]
 **sendDigits** | **String** | DTMF tones to play to the outdialed Call. This is typically used to dial a number and then dial an extension. |  [optional]
diff --git a/docs/OutDialAllOf.md b/docs/OutDialAllOf.md
@@ -9,8 +9,8 @@ Name | Type | Description | Notes
 ------------ | ------------- | ------------- | -------------
 **actionUrl** | **String** | URL to which FreeClimb sends an HTTP POST request.  | 
 **callConnectUrl** | **String** | URL to which FreeClimb makes an HTTP POST request informing the result of the OutDial. | 
-**callingNumber** | **BigDecimal** | he caller ID to show to the called party when FreeClimb calls. This can be one of the following: The To or From number provided in the first Webhook to your webserver. Any phone number you have purchased from FreeClimb. | 
-**destination** | **BigDecimal** | E.164 representation of the phone number to Call.  | 
+**callingNumber** | **String** | he caller ID to show to the called party when FreeClimb calls. This can be one of the following: The To or From number provided in the first Webhook to your webserver. Any phone number you have purchased from FreeClimb. | 
+**destination** | **String** | E.164 representation of the phone number to Call.  | 
 **ifMachine** | **IfMachine** |  |  [optional]
 **ifMachineUrl** | **String** | When the &#x60;ifMachine&#x60; flag is set to &#x60;redirect&#x60;, this attribute specifies a URL to which FreeClimb makes a POST request when an answering machine or a fax machine is detected. This URL is required if the &#x60;ifMachine&#x60; flag is set to &#x60;redirect&#x60;. Otherwise, it should not be included. |  [optional]
 **sendDigits** | **String** | DTMF tones to play to the outdialed Call. This is typically used to dial a number and then dial an extension. |  [optional]
diff --git a/openapi.json b/openapi.json
@@ -751,11 +751,11 @@
               },
               "callingNumber": {
                 "description": "he caller ID to show to the called party when FreeClimb calls. This can be one of the following: The To or From number provided in the first Webhook to your webserver. Any phone number you have purchased from FreeClimb.",
-                "type": "number"
+                "type": "string"
               },
               "destination": {
                 "description": "E.164 representation of the phone number to Call. ",
-                "type": "number"
+                "type": "string"
               },
               "ifMachine": {
                 "$ref": "#/components/schemas/IfMachine"
diff --git a/pom.xml b/pom.xml
@@ -5,7 +5,7 @@
     <artifactId>freeclimb-java-client</artifactId>
     <packaging>jar</packaging>
     <name>freeclimb-java-client</name>
-    <version>5.1.1</version>
+    <version>5.1.2</version>
     <url>https://github.com/freeclimbapi/java-sdk</url>
     <description>FreeClimb Java Client</description>
     <scm>
diff --git a/src/main/java/com/github/freeclimbapi/ApiClient.java b/src/main/java/com/github/freeclimbapi/ApiClient.java
@@ -131,7 +131,7 @@ private void init() {
         json = new JSON();
 
         // Set default User-Agent.
-        setUserAgent("OpenAPI-Generator/5.1.1/java");
+        setUserAgent("OpenAPI-Generator/5.1.2/java");
 
         authentications = new HashMap<String, Authentication>();
     }
diff --git a/src/main/java/com/github/freeclimbapi/models/OutDial.java b/src/main/java/com/github/freeclimbapi/models/OutDial.java
@@ -50,11 +50,11 @@ public class OutDial extends PerclCommand {
 
   public static final String SERIALIZED_NAME_CALLING_NUMBER = "callingNumber";
   @SerializedName(SERIALIZED_NAME_CALLING_NUMBER)
-  private BigDecimal callingNumber;
+  private String callingNumber;
 
   public static final String SERIALIZED_NAME_DESTINATION = "destination";
   @SerializedName(SERIALIZED_NAME_DESTINATION)
-  private BigDecimal destination;
+  private String destination;
 
   public static final String SERIALIZED_NAME_IF_MACHINE = "ifMachine";
   @SerializedName(SERIALIZED_NAME_IF_MACHINE)
@@ -130,7 +130,7 @@ public void setCallConnectUrl(String callConnectUrl) {
   }
 
 
-  public OutDial callingNumber(BigDecimal callingNumber) {
+  public OutDial callingNumber(String callingNumber) {
     
     this.callingNumber = callingNumber;
     return this;
@@ -143,17 +143,17 @@ public OutDial callingNumber(BigDecimal callingNumber) {
   @javax.annotation.Nonnull
   @ApiModelProperty(required = true, value = "he caller ID to show to the called party when FreeClimb calls. This can be one of the following: The To or From number provided in the first Webhook to your webserver. Any phone number you have purchased from FreeClimb.")
 
-  public BigDecimal getCallingNumber() {
+  public String getCallingNumber() {
     return callingNumber;
   }
 
 
-  public void setCallingNumber(BigDecimal callingNumber) {
+  public void setCallingNumber(String callingNumber) {
     this.callingNumber = callingNumber;
   }
 
 
-  public OutDial destination(BigDecimal destination) {
+  public OutDial destination(String destination) {
     
     this.destination = destination;
     return this;
@@ -166,12 +166,12 @@ public OutDial destination(BigDecimal destination) {
   @javax.annotation.Nonnull
   @ApiModelProperty(required = true, value = "E.164 representation of the phone number to Call. ")
 
-  public BigDecimal getDestination() {
+  public String getDestination() {
     return destination;
   }
 
 
-  public void setDestination(BigDecimal destination) {
+  public void setDestination(String destination) {
     this.destination = destination;
   }
 
diff --git a/src/main/java/com/github/freeclimbapi/models/OutDialAllOf.java b/src/main/java/com/github/freeclimbapi/models/OutDialAllOf.java
@@ -49,11 +49,11 @@ public class OutDialAllOf {
 
   public static final String SERIALIZED_NAME_CALLING_NUMBER = "callingNumber";
   @SerializedName(SERIALIZED_NAME_CALLING_NUMBER)
-  private BigDecimal callingNumber;
+  private String callingNumber;
 
   public static final String SERIALIZED_NAME_DESTINATION = "destination";
   @SerializedName(SERIALIZED_NAME_DESTINATION)
-  private BigDecimal destination;
+  private String destination;
 
   public static final String SERIALIZED_NAME_IF_MACHINE = "ifMachine";
   @SerializedName(SERIALIZED_NAME_IF_MACHINE)
@@ -128,7 +128,7 @@ public void setCallConnectUrl(String callConnectUrl) {
   }
 
 
-  public OutDialAllOf callingNumber(BigDecimal callingNumber) {
+  public OutDialAllOf callingNumber(String callingNumber) {
     
     this.callingNumber = callingNumber;
     return this;
@@ -141,17 +141,17 @@ public OutDialAllOf callingNumber(BigDecimal callingNumber) {
   @javax.annotation.Nonnull
   @ApiModelProperty(required = true, value = "he caller ID to show to the called party when FreeClimb calls. This can be one of the following: The To or From number provided in the first Webhook to your webserver. Any phone number you have purchased from FreeClimb.")
 
-  public BigDecimal getCallingNumber() {
+  public String getCallingNumber() {
     return callingNumber;
   }
 
 
-  public void setCallingNumber(BigDecimal callingNumber) {
+  public void setCallingNumber(String callingNumber) {
     this.callingNumber = callingNumber;
   }
 
 
-  public OutDialAllOf destination(BigDecimal destination) {
+  public OutDialAllOf destination(String destination) {
     
     this.destination = destination;
     return this;
@@ -164,12 +164,12 @@ public OutDialAllOf destination(BigDecimal destination) {
   @javax.annotation.Nonnull
   @ApiModelProperty(required = true, value = "E.164 representation of the phone number to Call. ")
 
-  public BigDecimal getDestination() {
+  public String getDestination() {
     return destination;
   }
 
 
-  public void setDestination(BigDecimal destination) {
+  public void setDestination(String destination) {
     this.destination = destination;
   }
 
diff --git a/src/test/java/com/github/freeclimbapi/OutDialAllOfTest.java b/src/test/java/com/github/freeclimbapi/OutDialAllOfTest.java
@@ -23,6 +23,8 @@
 import java.util.Map;
 import java.io.File;
 import java.math.BigDecimal;
+import java.net.URI;
+import java.net.URISyntaxException;
 import com.github.freeclimbapi.enums.*;
 import com.github.freeclimbapi.models.*;
 /**
@@ -60,9 +62,9 @@ public void callConnectUrlTest() {
     @Test
     public void callingNumberTest() {
 
+        model.setCallingNumber("TEST_STRING");
+        Assert.assertEquals("TEST_STRING", model.getCallingNumber());
         
-        model.setCallingNumber(new BigDecimal(1.0));
-        Assert.assertEquals(new BigDecimal(1.0), model.getCallingNumber());
         
     }
 
@@ -72,9 +74,9 @@ public void callingNumberTest() {
     @Test
     public void destinationTest() {
 
+        model.setDestination("TEST_STRING");
+        Assert.assertEquals("TEST_STRING", model.getDestination());
         
-        model.setDestination(new BigDecimal(1.0));
-        Assert.assertEquals(new BigDecimal(1.0), model.getDestination());
         
     }
 
diff --git a/src/test/java/com/github/freeclimbapi/OutDialTest.java b/src/test/java/com/github/freeclimbapi/OutDialTest.java
@@ -23,6 +23,8 @@
 import java.util.Map;
 import java.io.File;
 import java.math.BigDecimal;
+import java.net.URI;
+import java.net.URISyntaxException;
 import com.github.freeclimbapi.enums.*;
 import com.github.freeclimbapi.models.*;
 /**
@@ -69,9 +71,9 @@ public void callConnectUrlTest() {
     @Test
     public void callingNumberTest() {
 
+        model.setCallingNumber("TEST_STRING");
+        Assert.assertEquals("TEST_STRING", model.getCallingNumber());
         
-        model.setCallingNumber(new BigDecimal(1.0));
-        Assert.assertEquals(new BigDecimal(1.0), model.getCallingNumber());
         
     }
 
@@ -81,9 +83,9 @@ public void callingNumberTest() {
     @Test
     public void destinationTest() {
 
+        model.setDestination("TEST_STRING");
+        Assert.assertEquals("TEST_STRING", model.getDestination());
         
-        model.setDestination(new BigDecimal(1.0));
-        Assert.assertEquals(new BigDecimal(1.0), model.getDestination());
         
     }
 
@@ -156,9 +158,9 @@ public void privacyModeTest() {
     public void buildTest() throws Exception {
          
         model.setActionUrl("TEST_STRING");   
-        model.setCallConnectUrl("TEST_STRING");    
-        model.setCallingNumber(new BigDecimal(1.0));  
-        model.setDestination(new BigDecimal(1.0));   
+        model.setCallConnectUrl("TEST_STRING");   
+        model.setCallingNumber("TEST_STRING");   
+        model.setDestination("TEST_STRING");     
         model.setIfMachineUrl("TEST_STRING");   
         model.setSendDigits("TEST_STRING");   
         model.setStatusCallbackUrl("TEST_STRING");    

Original file line number	Diff line number	Diff line change
`@@ -131,7 +131,7 @@ private void init() {`
`131`	`131`	`json = new JSON();`
`132`	`132`
`133`	`133`	`// Set default User-Agent.`
`134`		`- setUserAgent("OpenAPI-Generator/5.1.1/java");`
	`134`	`+ setUserAgent("OpenAPI-Generator/5.1.2/java");`
`135`	`135`
`136`	`136`	`authentications = new HashMap<String, Authentication>();`
`137`	`137`	`}`