Suppress MISRA violations for static helper variables#372
Merged
AniruddhaKanhere merged 1 commit intoApr 28, 2026
Merged
Conversation
…L constants The static const uint8_t variables that back the MQTT_PROP_VALIDATE_* convenience macros get a private copy in every translation unit that includes core_mqtt_serializer.h. A TU that does not use a particular MQTT_PROP_VALIDATE_* macro leaves the corresponding variable unreferenced, which Coverity flags as MISRA Rule 2.2 (dead code) and Rule 2.8 (unused file-scope object definition). Add coverity[misra_c_2012_rule_2_2_violation] and coverity[misra_c_2012_rule_2_8_violation] suppressions above each static const declaration, with links to MISRA.md. Add Rule 2.2 and Rule 2.8 sections to MISRA.md documenting the rationale: the variables exist so the address-of operator in the macros produces a valid const uint8_t *, and the portable-to-C90 alternative (compound literals) is not viable.
AniruddhaKanhere
force-pushed
the
ConvenienceMacrosWithMISRA
branch
from
375e5de to
176b6bf
Compare
patrzhan
approved these changes
Apr 28, 2026
AniruddhaKanhere
changed the title
cookpate
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The static const uint8_t variables that back the MQTT_PROP_VALIDATE_* convenience macros get a private copy in every translation unit that includes core_mqtt_serializer.h. A TU that does not use a particular MQTT_PROP_VALIDATE_* macro leaves the corresponding variable unreferenced, which Coverity flags as MISRA Rule 2.2 (dead code) and Rule 2.8 (unused file-scope object definition).
Add coverity[misra_c_2012_rule_2_2_violation] and
coverity[misra_c_2012_rule_2_8_violation] suppressions above each static const declaration, with links to MISRA.md. Add Rule 2.2 and Rule 2.8 sections to MISRA.md documenting the rationale: the variables exist so the address-of operator in the macros produces a valid const uint8_t *, and the portable-to-C90 alternative (compound literals) is not viable.
Description
Test Steps
Checklist:
Related Issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.