Skip to content

Commit 84d3fd1

Browse files
Replacing reduce with Object.fromEntries. (#24411)
1 parent 7a7ab7d commit 84d3fd1

File tree

1 file changed

+3
-12
lines changed

1 file changed

+3
-12
lines changed

graylog2-web-interface/src/components/cluster-configuration/data-nodes/useAddMetricsToDataNodes.ts

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -49,17 +49,14 @@ type MetricsSummaryResponse = {
4949
};
5050

5151
const buildMetricsWithDefaults = (metrics: Partial<DataNodeMetrics> = {}): DataNodeMetrics =>
52-
METRIC_SHORT_NAMES.reduce<DataNodeMetrics>((acc, key) => ({ ...acc, [key]: metrics[key] }), {} as DataNodeMetrics);
52+
Object.fromEntries(METRIC_SHORT_NAMES.map((key) => [key, metrics[key]]));
5353

5454
const toNodeMetric = (response?: MetricsSummaryResponse): NodeMetric | undefined => {
5555
if (!response?.metrics?.length) {
5656
return undefined;
5757
}
5858

59-
return response.metrics.reduce<NodeMetric>(
60-
(acc, metric) => ({ ...acc, [metric.full_name]: metric }),
61-
{} as NodeMetric,
62-
);
59+
return Object.fromEntries(response.metrics.map((metric) => [metric.full_name, metric]));
6360
};
6461

6562
const extractMetrics = (response?: MetricsSummaryResponse): DataNodeMetrics => {
@@ -91,13 +88,7 @@ const fetchMetricsForHostnames = async (hostnames: string[]) => {
9188
hostnames.map(async (hostname) => ({ hostname, response: await fetchMetrics(hostname) })),
9289
);
9390

94-
return responses.reduce<Record<string, DataNodeMetrics>>(
95-
(acc, { hostname, response }) => ({
96-
...acc,
97-
[hostname]: extractMetrics(response),
98-
}),
99-
{},
100-
);
91+
return Object.fromEntries(responses.map(({ hostname, response }) => [hostname, extractMetrics(response)]));
10192
};
10293

10394
type UseAddMetricsToDataNodesOptions = {

0 commit comments

Comments
 (0)