address review feedback

Author: ndgrigorian

docs/doc_sources/api_reference/dpctl/program.rst

@@ -31,6 +31,7 @@ execution via :py:meth:`dpctl.SyclQueue.submit`.
 
     SyclKernelBundle
     SyclKernel
+    SpecializationConstant
 
 .. autosummary::
     :toctree: generated

dpctl/program/_program.pyx

@@ -288,11 +288,11 @@ cdef class SpecializationConstant:
       data in the buffer
 
     - ``SpecializationConstant(spec_id, dtype, obj)``
-    If the constructor is invoked with two variadic arguments, and the first
-    argument is a string, it is interpreted as a NumPy ``dtype`` string and the
-    second argument will be coerced to a NumPy array with that data type.
-    The data type specified by the first argument must be a supported data
-    type (bool, integral, or floating point).
+      If the constructor is invoked with two variadic arguments, and the first
+      argument is a string, it is interpreted as a NumPy ``dtype`` string and
+      the second argument will be coerced to a NumPy array with that data type.
+      The data type specified by the first argument must be a supported data
+      type (bool, integral, or floating point).
 
     - ``SpecializationConstant(spec_id, nbytes, raw_ptr)``
       If the constructor is invoked with two variadic arguments where both are
@@ -406,10 +406,11 @@ cdef class SpecializationConstant:
         cdef SpecializationConstant _other = <SpecializationConstant>other
         if (
             self._spec_const.id != _other._spec_const.id or
-            self._spec_const.size != _other._spec_const.size or
-            self._spec_const.value != _other._spec_const.value
+            self._spec_const.size != _other._spec_const.size
         ):
             return False
+        if self._spec_const.value == _other._spec_const.value:
+            return True
         return memcmp(
             self._spec_const.value,
             _other._spec_const.value,

dpctl/program/utils/__init__.py

@@ -18,8 +18,9 @@
 A collection of utility functions for dpctl.program module.
 """
 
-from ._utils import parse_spirv_specializations
+from ._utils import SpecializationConstantInfo, parse_spirv_specializations
 
 __all__ = [
     "parse_spirv_specializations",
+    "SpecializationConstantInfo",
 ]

libsyclinterface/source/dpctl_sycl_kernel_bundle_interface.cpp

@@ -297,8 +297,25 @@ _CreateKernelBundleWithIL_ocl_impl(const context &ctx,
         auto clSetProgramSpecConstF = get_clSetProgramSpecializationConstant();
         if (clSetProgramSpecConstF) {
             for (size_t i = 0; i < NumSpecConsts; ++i) {
-                clSetProgramSpecConstF(clProgram, SpecConsts[i].id,
-                                       SpecConsts[i].size, SpecConsts[i].value);
+                cl_int spec_err = clSetProgramSpecConstF(
+                    clProgram, SpecConsts[i].id, SpecConsts[i].size,
+                    SpecConsts[i].value);
+                if (spec_err != CL_SUCCESS) {
+                    error_handler(
+                        "clSetProgramSpecializationConstant failed for "
+                        "spec constant id " +
+                            std::to_string(SpecConsts[i].id) +
+                            ". OpenCL Error " +
+                            _GetErrorCode_ocl_impl(spec_err),
+                        __FILE__, __func__, __LINE__);
+
+                    auto clReleaseProgramF = get_clReleaseProgram();
+                    if (clReleaseProgramF) {
+                        clReleaseProgramF(clProgram);
+                    }
+
+                    return nullptr;
+                }
             }
         }
         else {