test: refactor and expand unit tests

Author: JiHong88

jest.config.js

@@ -29,10 +29,10 @@ module.exports = {
 	// Coverage thresholds
 	coverageThreshold: {
 		global: {
-			statements: 62,
-			branches: 53,
-			functions: 75,
-			lines: 63,
+			statements: 70,
+			branches: 60,
+			functions: 80,
+			lines: 70,
 		},
 	},
 

src/core/event/handlers/handler_ww_key.js

@@ -127,7 +127,11 @@ export async function OnKeyUp_wysiwyg(fc, e) {
 
 		selectionNode.innerHTML = '';
 
-		const oFormatTag = dom.utils.createElement(this.format.isLine(this.status.currentNodes[0]) && !dom.check.isListCell(this.status.currentNodes[0]) ? this.status.currentNodes[0] : this.options.get('defaultLine'), null, '<br>');
+		const oFormatTag = dom.utils.createElement(
+			this.format.isLine(this.status.currentNodes[0]) && !dom.check.isListCell(this.status.currentNodes[0]) ? this.status.currentNodes[0].nodeName : this.options.get('defaultLine'),
+			null,
+			'<br>',
+		);
 		selectionNode.appendChild(oFormatTag);
 		this.selection.setRange(oFormatTag, 0, oFormatTag, 0);
 		this.applyTagEffect();

src/helper/converter.js

@@ -230,7 +230,7 @@ export function kebabToCamelCase(param) {
 		return param.replace(/-[a-zA-Z]/g, (letter) => letter.replace('-', '').toUpperCase());
 	} else {
 		return param.map(function (str) {
-			return camelToKebabCase(str);
+			return kebabToCamelCase(str);
 		});
 	}
 }
@@ -441,10 +441,6 @@ export function spanToStyleNode(styleToTag, node) {
 				currentNode = nextNode;
 			}
 
-			while (node.firstChild) {
-				node.removeChild(node.firstChild);
-			}
-
 			node.appendChild(temp);
 		}
 	}

src/helper/dom/domCheck.js

@@ -263,11 +263,9 @@ export function isSameAttributes(a, b) {
 
 	const class_a = aEl.classList;
 	const class_b = bEl.classList;
-	const wRegExp = RegExp;
 	let compClass = 0;
-
 	for (let i = 0, len = class_a.length; i < len; i++) {
-		if (wRegExp('(s|^)' + class_a[i] + '(s|$)').test(class_b.value)) compClass++;
+		if (class_b.contains(class_a[i])) compClass++;
 	}
 
 	return compStyle === style_b.length && compStyle === style_a.length && compClass === class_b.length && compClass === class_a.length;

src/helper/dom/domQuery.js

@@ -247,6 +247,25 @@ export function sortNodeByDepth(array, des) {
 export function compareElements(a, b) {
 	let aNode = a,
 		bNode = b;
+
+	// Equalize depth
+	const aDepth = getNodeDepth(a);
+	const bDepth = getNodeDepth(b);
+
+	if (aDepth > bDepth) {
+		let diff = aDepth - bDepth;
+		while (diff > 0 && aNode) {
+			aNode = aNode.parentElement;
+			diff--;
+		}
+	} else if (bDepth > aDepth) {
+		let diff = bDepth - aDepth;
+		while (diff > 0 && bNode) {
+			bNode = bNode.parentElement;
+			diff--;
+		}
+	}
+
 	while (aNode && bNode && aNode.parentElement !== bNode.parentElement) {
 		aNode = aNode.parentElement;
 		bNode = bNode.parentElement;

src/helper/env.js

@@ -91,16 +91,16 @@ export function getIncludePath(nameArray, extension) {
 		}
 	}
 
+	if (!path) {
+		throw '[SUNEDITOR.helper.env.getIncludePath.fail] The SUNEDITOR installation path could not be automatically detected. (path: +' + path + ', extension: ' + extension + ')';
+	}
+
 	if (path === '') path = pathList.length > 0 ? pathList[0][src] : '';
 
 	if (!path.includes(':/') && '//' !== path.slice(0, 2)) {
 		path = false === path.includes('/') ? location.href.match(/^.*?:\/\/[^/]*/)[0] + path : location.href.match(/^[^?]*\/(?:)/)[0] + path;
 	}
 
-	if (!path) {
-		throw '[SUNEDITOR.helper.env.getIncludePath.fail] The SUNEDITOR installation path could not be automatically detected. (path: +' + path + ', extension: ' + extension + ')';
-	}
-
 	return path;
 }