Update openjdk to version 21 #153
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR updates the dotfiles to install openjdk@21 instead of openjdk@11. The
new datastore emulator requires openjdk@21[1]. Our java code (specifically, our
dataflow jobs) have been updated to be compatible with openjdk@21[2].
[1] https://khanacademy.slack.com/archives/CDHPTMSTB/p1764100041132309
[2] https://khanacademy.slack.com/archives/C02NV1DPJ/p1761164767463419?thread_ts=1758663304.942309&cid=C02NV1DPJ
Issue: https://khanacademy.slack.com/archives/C02NV1DPJ/p1764186772736169?thread_ts=1758663304.942309&cid=C02NV1DPJ
Test plan:
Making this change I ran:
which output:
After making this change I ran the dotfiles:
This ran successfully.
I then opened a new terminal window, and ran the following again:
which output:
I also ran:
and the datastore emulator started up on port 5555 without issue.
(Note: I needed to update by macOS to version 26.1 to successfully run
khan-dotfiles, but after doing that everything ran just fine.)