Skip to content

Conversation

@nishasy
Copy link
Contributor

@nishasy nishasy commented Dec 5, 2025

Summary:

Create a generator for the Numeric Input widget to make testdata easier to read and write.

Issue: https://khanacademy.atlassian.net/browse/LEMS-3771

Test plan:

pnpm jest

@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2025

🗄️ Schema Change: No Changes ✅

@nishasy nishasy marked this pull request as ready for review December 5, 2025 01:17
@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2025

Size Change: +33 B (+0.01%)

Total Size: 498 kB

Filename Size Change
packages/perseus-core/dist/es/index.js 24.9 kB +76 B (+0.31%)
packages/perseus/dist/es/index.js 200 kB -43 B (-0.02%)
ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 20.8 kB
packages/keypad-context/dist/es/index.js 1 kB
packages/kmath/dist/es/index.js 5.98 kB
packages/math-input/dist/es/index.js 99.2 kB
packages/math-input/dist/es/strings.js 1.61 kB
packages/perseus-core/dist/es/index.item-splitting.js 13.1 kB
packages/perseus-editor/dist/es/index.js 97.9 kB
packages/perseus-linter/dist/es/index.js 8.64 kB
packages/perseus-score/dist/es/index.js 9.2 kB
packages/perseus-utils/dist/es/index.js 403 B
packages/perseus/dist/es/strings.js 7.73 kB
packages/pure-markdown/dist/es/index.js 1.39 kB
packages/simple-markdown/dist/es/index.js 6.72 kB

compressed-size-action

@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2025

🛠️ Item Splitting: No Changes ✅

@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2025

npm Snapshot: Published

Good news!! We've packaged up the latest commit from this PR (df88f31) and published it to npm. You
can install it using the tag PR3093.

Example:

pnpm add @khanacademy/perseus@PR3093

If you are working in Khan Academy's frontend, you can run the below command.

./dev/tools/bump_perseus_version.ts -t PR3093

If you are working in Khan Academy's webapp, you can run the below command.

./dev/tools/bump_perseus_version.js -t PR3093

@nishasy nishasy removed the request for review from benchristel December 5, 2025 21:50
content:
"Enter the number $$-42$$ in the box: [[\u2603 numeric-input 1]]",
images: {},
"Enter the number $$42$$ in the box: [[\u2603 numeric-input 1]]",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be a minus sign in front of the 42 (negative 42)?

Copy link
Contributor

@mark-fitzgerald mark-fitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Great to have the test data all in a central location and easily accessible!!

Base automatically changed from expression-generator to main December 8, 2025 23:49
@nishasy nishasy merged commit de07b91 into main Dec 8, 2025
11 checks passed
@nishasy nishasy deleted the numeric-input-generator branch December 8, 2025 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants