[DO NOT MERGE] MaybeNativeDatePicker test branch #2892
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses WB-2016
🦋 Changeset detectedLatest commit: 1ceea52 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Size Change: +6.03 kB (+5.53%) 🔍 Total Size: 115 kB
ℹ️ View Unchanged
|
Contributor
A new build was pushed to Chromatic! 🚀https://5e1bf4b385e3fb0020b7073c-itrlwrlfpi.chromatic.com/ Chromatic results:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feature/datepicker #2892 +/- ##
==========================================
==========================================
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Member
Author
|
After testing on iOS and Android Emulators on the most common versions listed in https://caniuse.com/usage-table, I think we can safely drop the MaybeNativeDatePicker wrapper. The calendar overlay works fine on iOS Safari 18.6 and Chrome 134 (even older than the most common one, 142). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Test branch to determine whether we need
MaybeNativeDatePickeror justDatePicker. The frontend repo definitely uses this extra wrapper, but we removed it from the initial migration PR: #2876This draft PR exists to test this wrapper further and gather intel on it.
Issue: WB-1112
Test plan: