feat: use C++ threads and messaging for workers mirroring iOS implementation and handle SharedArrayBuffer

Author: edusperoni

test-app/app/src/main/assets/app/mainpage.js

@@ -49,6 +49,7 @@ require("./tests/requireExceptionTests");
 require("./tests/java-array-test");
 require("./tests/field-access-test");
 require("./tests/byte-buffer-test");
+require("./tests/shared-array-buffer-test");
 require("./tests/dex-interface-implementation");
 require("./tests/testInterfaceImplementation");
 require("./tests/testRuntimeImplementedAPIs");

test-app/app/src/main/assets/app/tests/shared-array-buffer-test.js

@@ -0,0 +1,76 @@
+describe("Tests SharedArrayBuffer conversion", function () {
+	it("should pass a SharedArrayBuffer to a Java method expecting ByteBuffer", function () {
+		var sab = new SharedArrayBuffer(8);
+		var view = new Uint8Array(sab);
+		for (var i = 0; i < 8; i++) {
+			view[i] = i + 1;
+		}
+
+		// resolves the ByteBuffer.put(ByteBuffer) overload and copies from the
+		// direct buffer created over the SharedArrayBuffer's memory
+		var bb = java.nio.ByteBuffer.allocateDirect(8);
+		bb.put(sab);
+		bb.flip();
+
+		var roundTripped = new Uint8Array(ArrayBuffer.from(bb));
+		for (var i = 0; i < 8; i++) {
+			expect(roundTripped[i]).toBe(i + 1);
+		}
+	});
+
+	it("should respect byteOffset and length of typed array views over a SharedArrayBuffer", function () {
+		var sab = new SharedArrayBuffer(16);
+		var full = new Uint8Array(sab);
+		for (var i = 0; i < 16; i++) {
+			full[i] = i;
+		}
+
+		var slice = new Uint8Array(sab, 4, 8); // bytes 4..11
+
+		var bb = java.nio.ByteBuffer.allocateDirect(8);
+		bb.put(slice);
+		bb.flip();
+
+		var roundTripped = new Uint8Array(ArrayBuffer.from(bb));
+		for (var i = 0; i < 8; i++) {
+			expect(roundTripped[i]).toBe(i + 4);
+		}
+	});
+
+	it("should share memory between the SharedArrayBuffer and the Java buffer (no copy)", function () {
+		var sab = new SharedArrayBuffer(4);
+		var view = new Uint8Array(sab);
+		view[0] = 42;
+
+		// requireNonNull returns its argument, handing back the direct
+		// ByteBuffer the runtime created over the SharedArrayBuffer's memory
+		var javaBuf = java.util.Objects.requireNonNull(sab);
+		expect(javaBuf.get(0)).toBe(42);
+
+		// mutations after the call are visible through the Java buffer
+		view[0] = 99;
+		expect(javaBuf.get(0)).toBe(99);
+	});
+
+	it("should share a SharedArrayBuffer's memory with a worker and a Java buffer at once", function (done) {
+		var sab = new SharedArrayBuffer(4);
+		var view = new Int32Array(sab);
+		view[0] = 0;
+
+		var javaBuf = java.util.Objects.requireNonNull(sab);
+
+		var worker = new Worker("../shared/Workers/EvalWorker.js");
+		worker.postMessage({
+			value: sab,
+			eval: "var v = new Int32Array(value); v[0] = 1234; postMessage('written');"
+		});
+		worker.onmessage = function (msg) {
+			expect(msg.data).toBe("written");
+			// the worker's write is visible both to this isolate and to Java
+			expect(view[0]).toBe(1234);
+			expect(javaBuf.getInt(0)).toBe(1234);
+			worker.terminate();
+			done();
+		};
+	});
+});

test-app/runtime/CMakeLists.txt

@@ -99,6 +99,7 @@ add_library(
         src/main/cpp/ArrayHelper.cpp
         src/main/cpp/AssetExtractor.cpp
         src/main/cpp/CallbackHandlers.cpp
+        src/main/cpp/ConcurrentQueue.cpp
         src/main/cpp/Constants.cpp
         src/main/cpp/DirectBuffer.cpp
         src/main/cpp/FieldAccessor.cpp
@@ -112,6 +113,7 @@ add_library(
         src/main/cpp/JsArgToArrayConverter.cpp
         src/main/cpp/JSONObjectHelper.cpp
         src/main/cpp/Logger.cpp
+        src/main/cpp/LooperTasks.cpp
         src/main/cpp/ManualInstrumentation.cpp
         src/main/cpp/MessageLoopTimer.cpp
         src/main/cpp/MetadataMethodInfo.cpp
@@ -135,6 +137,8 @@ add_library(
         src/main/cpp/V8GlobalHelpers.cpp
         src/main/cpp/V8StringConstants.cpp
         src/main/cpp/WeakRef.cpp
+        src/main/cpp/WorkerMessage.cpp
+        src/main/cpp/WorkerWrapper.cpp
         src/main/cpp/Timers.cpp
         src/main/cpp/com_tns_AssetExtractor.cpp
         src/main/cpp/com_tns_Runtime.cpp