Skip to content

Commit a835f77

Browse files
author
Stephanie Reeder
committed
fix typos found by tests
1 parent e82db59 commit a835f77

File tree

5 files changed

+10
-8
lines changed

5 files changed

+10
-8
lines changed

odm2api/ODM2/services/readService.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -796,7 +796,7 @@ def getRelatedModels(self, id=None, code=None):
796796

797797
m = self._session.query(Models).select_from(RelatedModels).join(RelatedModels.RelatedModelObj)
798798
if id: m = m.filter(RelatedModels.ModelID == id)
799-
if code: m = m.filter(RelatedModels.ModelCode == code)
799+
if code: m = m.filter(Models.ModelCode == code)
800800

801801
try:
802802
return m.all()

tests/test_odm2/data/empty.sql

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -278,6 +278,7 @@ BEGIN TRANSACTION;CREATE TABLE ActionAnnotations (
278278
SamplingFeatureDescription VARCHAR (500) NULL,
279279
SamplingFeatureGeotypeCV VARCHAR (255) NULL,
280280
FeatureGeometry geometry NULL,
281+
FeatureGeometryWKT VARCHAR (50) NULL,
281282
Elevation_m FLOAT NULL,
282283
ElevationDatumCV VARCHAR (255) NULL,
283284
FOREIGN KEY (ElevationDatumCV) REFERENCES CV_ElevationDatum (Name)

tests/test_odm2/data/populated.sql

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -330,6 +330,7 @@ CREATE TABLE SamplingFeatures (
330330
SamplingFeatureDescription VARCHAR (500) NULL,
331331
SamplingFeatureGeotypeCV VARCHAR (255) NULL,
332332
FeatureGeometry geometry NULL,
333+
FeatureGeometryWKT VARCHAR(50) NULL,
333334
Elevation_m FLOAT NULL,
334335
ElevationDatumCV VARCHAR (255) NULL,
335336
FOREIGN KEY (ElevationDatumCV) REFERENCES CV_ElevationDatum (Name)

tests/test_odm2/test_createservice.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -63,8 +63,8 @@ def test_createVariable(self):
6363
nodv = -9999
6464
speciation="mg/L as PO4"
6565
definition="This is a test variable"
66-
v = models.Variables(VariableCode = code, VariableName=name, VariableTypeCV=vType, NoDataValue= nodv, Speciation = speciation,
67-
Definition=definition)
66+
v = models.Variables(VariableCode = code, VariableNameCV=name, VariableTypeCV=vType, NoDataValue= nodv, SpeciationCV = speciation,
67+
VariableDefinition=definition)
6868
# self.writer.createVariable(code = code,name = name,vType = vType,nodv =nodv,speciation=None,definition=None)
6969
self.writer.createVariable(v)
7070
# assert that this dataset has been successfully inserted
@@ -164,7 +164,7 @@ def test_createDataset(self):
164164
# dstitle=title,
165165
# dsabstract=desc)
166166
#TODO uuid
167-
d = models.Datasets(DataSetTypeCV = type, DataSetCode =code, DataSetTitle=title, DataSetAbstract = desc)
167+
d = models.DataSets(DataSetTypeCV = type, DataSetCode =code, DataSetTitle=title, DataSetAbstract = desc)
168168
dataset = self.writer.createDataset(d)
169169

170170

@@ -309,9 +309,9 @@ def test_createSimulation(self):
309309
SimulationName ="MySimulation",
310310
SimulationDescription = "My simulation description",
311311
SimulationsStartDateTime = st,
312-
SimulationStartOffset=6,
312+
SimulationStartDateTimeUTCOffset=6,
313313
SimulationEdnDateTime=et,
314-
SimulationEndOffset=6,
314+
SimulationEndDateTimeUTCOffset=6,
315315
TimeStepValue=1,
316316
TimeStepuUnitsID=1,
317317
InputDataSetID=None

tests/test_odm2/test_readservice.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ def test_getModelByCode(self):
110110

111111

112112
# get the model using the api
113-
resapi = self.reader.getModels(code=modelCode)
113+
resapi = self.reader.getModels(codes=[modelCode])
114114

115115
assert resapi is not None
116116

@@ -212,7 +212,7 @@ def test_getSimulationByActionID(self):
212212

213213
# get simulation by actionid using the api
214214
# resapi = self.reader.getSimulationByActionID(actionID=actionID)
215-
resapi = self.reader.getSimulation(actionid=actionID)
215+
resapi = self.reader.getSimulations(actionid=actionID)
216216
assert resapi is not None
217217

218218
def test_getResultsBySimulationID(self):

0 commit comments

Comments
 (0)