Add omitempty to Audience#422
Merged
Merged
Conversation
denys-octopus
approved these changes
Jun 9, 2026
|
|
||
| type OIDCIdentity struct { | ||
| Audience string `json:"Audience"` | ||
| Audience string `json:"Audience,omitempty"` |
Contributor
There was a problem hiding this comment.
Note that this can potentially change behaviour of the endpoint if endpoint treats differently null and empty values.
Contributor
Author
There was a problem hiding this comment.
It does change the behaviour (Audience no longer gets set with an empty string value) but that's the intended result because the current behaviour results in the existing bug. I don't think anyone would be reliant on this behaviour, what do you think?
Contributor
There was a problem hiding this comment.
I don't think so, but wanted to raise the question to confirm that you were aware of it :) 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Audience is being initialized in the TFP as an empty string rather than
nullwhen no value is provided. This leads to it being attempted to be used in Octopus which can result in the following error:Fixes #338