Fix HostingExample storyboard settings for mac destinations#897
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #897 +/- ##
==========================================
+ Coverage 26.70% 26.71% +0.01%
==========================================
Files 697 697
Lines 48907 48907
==========================================
+ Hits 13061 13067 +6
+ Misses 35846 35840 -6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
🤖 Augment PR SummarySummary: Restricts HostingExample storyboard-related Info.plist settings and storyboard resources to iOS/visionOS builds so mac destinations no longer fail due to unsupported storyboard target device types. 🤖 Was this summary useful? React with 👍 or 👎 |
| "revision" : "6675bc0ff86e61436e615df6fc5174e043e57924", | ||
| "version" : "1.4.1" | ||
| "revision" : "fea17c02d767f46b23070fdfdacc28a03a39232a", | ||
| "version" : "1.5.1" |
There was a problem hiding this comment.
This bumps swift-collections from 1.4.1 to 1.5.1; since the PR is focused on storyboard settings, can you confirm this dependency update is intentional (and needed) rather than an incidental change from regenerating files?
Severity: low
Other Locations
Example/Example_Legacy.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved:2
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
Closes #896
Summary
HostingExample/Base.lprojstoryboard resources only for iOS and visionOS destinations.Why
HostingExample applies iOS storyboard configuration to mac destinations. Xcode then reports that
LaunchScreen.storyboardandMain.storyboarddo not support target device type "mac".Validation
Example/setup.sh.Example.xcworkspacesuccessfully.