[Bug] Splatting is not picked up when running Convert-ADTDeployment

[PZan]

Prerequisites

• Ensure you write a short, descriptive title after [Bug] above.
• Make sure to search for any existing issues before filing a new one.
• Verify you are able to reproduce the issue with the latest released version

PSAppDeployToolkit.Tools version

0.2.3

PSAppDeployToolkit version

4.0.5

Describe the bug

I did scroll through all issues, and I don't think there's any reports of this one. Excuse me if I'm mistaken.

I attempted converting a package and upon inspecting the results i noticed that splats weren't included in the converted command. Here's an example:

$InstallSplat = @{
	Path = Join-Path $dirFiles -ChildPath "Setup.exe"
	Parameters = "/VERYSILENT /SUPPRESSMSGBOXES /NORESTART /LOG=`"$($configToolkitLogDir)\$($appName)_$($appVersion)_install_exe.log`""
}
Execute-Process @InstallSplat

got converted to

$InstallSplat = @{
	Path = Join-Path $adtSession.DirFiles -ChildPath "Setup.exe"
	Parameters = "/VERYSILENT /SUPPRESSMSGBOXES /NORESTART /LOG=`"$(if ($isAdmin) { (Get-ADTConfig).Toolkit.LogPath } else { (Get-ADTConfig).Toolkit.LogPathNoAdminRights })\$($adtSession.AppName)_$($adtSession.AppVersion)_install_exe.log`""
}
Start-ADTProcess 

As you can see there's actually two issues here:

• InstallSplat hashtable isn't added to the Start-ADTProcess command.
• The variables within the splat aren't converted, as these should now be FilePath and ArgumentList.

I haven't dived much deeper into this, but VSCode quickly had me on alert as it warned me about unused variables. My team is heavily into splatting, so adding support for this would be much appreciated.

Also pretty gnarly conversion of the value for the Parameters variable :)

Steps to reproduce

Explained in description

Environment data

OsName               : Microsoft Windows 11 Enterprise
OsOperatingSystemSKU : EnterpriseEdition
OsArchitecture       : 64-biters
WindowsVersion       : 2009
WindowsProductName   : Windows 10 Enterprise
WindowsBuildLabEx    : 22621.1.amd64fre.ni_release.220506-1250
OsLanguage           : nb-NO
OsMuiLanguages       : {nb-NO}
KeyboardLayout       : nb-NO
TimeZone             : (UTC+01:00) Amsterdam, Berlin, Bern, Oslo, Roma, Wien
HyperVisorPresent    : True
CsPartOfDomain       : False
CsPCSystemType       : Mobile

dotnet: The term 'dotnet' is not recognized as a name of a cmdlet, function, script file, or executable program.
Check the spelling of the name, or if a path was included, verify that the path is correct and try again.

[DanGough]

I've made progress on this; splats are now processed, however PSScriptAnalyzer does not like it when there are conflicting changes to apply to the same line with how I have it set up right now. With the code currently in Main, your example successfully reports all issues:

RuleName                            Severity     ScriptName Line  Message
--------                            --------     ---------- ----  -------
Measure-ADTCompatibility            Warning      MigrationT 1     Modify splat $InstallSplat:
                                                 est.ps1          Path = Join-Path $dirFiles -ChildPath "Setup.exe"  →
                                                                  FilePath = Join-Path $dirFiles -ChildPath "Setup.exe"
                                                                  Parameters = "/VERYSILENT /SUPPRESSMSGBOXES /NORESTART /LOG=
                                                                  `"$($configToolkitLogDir)\$($appName)_$($appVersion)_install
                                                                  _exe.log`""  →  ArgumentList = "/VERYSILENT
                                                                  /SUPPRESSMSGBOXES /NORESTART /LOG=`"$($configToolkitLogDir)\
                                                                  $($appName)_$($appVersion)_install_exe.log`""
Measure-ADTCompatibility            Warning      MigrationT 2     The variable [$dirFiles] is now a session variable and no
                                                 est.ps1          longer directly available. Use [$adtSession.DirFiles]
                                                                  instead.
Measure-ADTCompatibility            Warning      MigrationT 3     The variable [$configToolkitLogDir] is now a config
                                                 est.ps1          variable and no longer directly available. Use [if
                                                                  ($isAdmin) { (Get-ADTConfig).Toolkit.LogPath } else {
                                                                  (Get-ADTConfig).Toolkit.LogPathNoAdminRights }] instead.
Measure-ADTCompatibility            Warning      MigrationT 3     The variable [$appName] is now a session variable and no
                                                 est.ps1          longer directly available. Use [$adtSession.AppName]
                                                                  instead.
Measure-ADTCompatibility            Warning      MigrationT 3     The variable [$appVersion] is now a session variable and no
                                                 est.ps1          longer directly available. Use [$adtSession.AppVersion]
                                                                  instead.
Measure-ADTCompatibility            Warning      MigrationT 5     The function [Execute-Process] is deprecated, use
                                                 est.ps1          [Start-ADTProcess] instead.

Yet it fails to convert due to conflicts on line 3. The following examples that do not try to use multiple variables per line do convert though:

$InstallSplat = @{
	Path = Join-Path $dirFiles -ChildPath "Setup.exe"
	Parameters = "/VERYSILENT /SUPPRESSMSGBOXES /NORESTART /LOG=`"$($configToolkitLogDir)\install_exe.log`""
}
Execute-Process @InstallSplat

$InstallSplat = @{
	Path = Join-Path $dirFiles -ChildPath "Setup.exe"
	Parameters = "/VERYSILENT /SUPPRESSMSGBOXES /NORESTART /LOG=`"$($appVersion)_install_exe.log`""
}
Execute-Process @InstallSplat

$InstallSplat = @{
	Path = Join-Path $dirFiles -ChildPath "Setup.exe"
	Parameters = "/VERYSILENT /SUPPRESSMSGBOXES /NORESTART /LOG=`"$($appName)_install_exe.log`""
}
Execute-Process @InstallSplat

I'll leave this open until I've managed to address this fully!