From 2f4586249dc3d4989bc6a100fe7d36a468d6ed1f Mon Sep 17 00:00:00 2001 From: Shiv Date: Thu, 6 Aug 2026 09:49:33 -0700 Subject: [PATCH 1/5] Fix msgpack symbol conflict --- cmake/ExportHeader.cmake | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/cmake/ExportHeader.cmake b/cmake/ExportHeader.cmake index cec4f5441fa..0865fe6eb29 100644 --- a/cmake/ExportHeader.cmake +++ b/cmake/ExportHeader.cmake @@ -39,6 +39,12 @@ function(migraphx_generate_export_header TARGET) string(REPLACE "_" "/" __directory ${TARGET}) string(TOLOWER ${__directory} __directory) endif() + if(NOT WIN32) + set_target_properties(${TARGET} PROPERTIES + C_VISIBILITY_PRESET hidden + CXX_VISIBILITY_PRESET hidden + VISIBILITY_INLINES_HIDDEN YES) + endif() set(__file_name ${CMAKE_CURRENT_BINARY_DIR}/include/${__directory}/export.h) generate_export_header(${TARGET} EXPORT_FILE_NAME ${__file_name}) target_include_directories(${TARGET} PUBLIC $) From b971d7a5500a215cd5ff32197aa39fc21240a12e Mon Sep 17 00:00:00 2001 From: Shiv Date: Thu, 6 Aug 2026 12:53:51 -0700 Subject: [PATCH 2/5] add missing gpu exports --- cmake/ExportHeader.cmake | 2 +- src/targets/gpu/include/migraphx/gpu/hip_gemm_impl.hpp | 7 ++++--- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/cmake/ExportHeader.cmake b/cmake/ExportHeader.cmake index 0865fe6eb29..dc4db361420 100644 --- a/cmake/ExportHeader.cmake +++ b/cmake/ExportHeader.cmake @@ -1,7 +1,7 @@ ##################################################################################### # The MIT License (MIT) # -# Copyright (c) 2015-2023 Advanced Micro Devices, Inc. All rights reserved. +# Copyright (c) 2015-2026 Advanced Micro Devices, Inc. All rights reserved. # # Permission is hereby granted, free of charge, to any person obtaining a copy # of this software and associated documentation files (the "Software"), to deal diff --git a/src/targets/gpu/include/migraphx/gpu/hip_gemm_impl.hpp b/src/targets/gpu/include/migraphx/gpu/hip_gemm_impl.hpp index a766a741a1f..ef4be312d9e 100644 --- a/src/targets/gpu/include/migraphx/gpu/hip_gemm_impl.hpp +++ b/src/targets/gpu/include/migraphx/gpu/hip_gemm_impl.hpp @@ -1,7 +1,7 @@ /* * The MIT License (MIT) * - * Copyright (c) 2015-2025 Advanced Micro Devices, Inc. All rights reserved. + * Copyright (c) 2015-2026 Advanced Micro Devices, Inc. All rights reserved. * * Permission is hereby granted, free of charge, to any person obtaining a copy * of this software and associated documentation files (the "Software"), to deal @@ -24,6 +24,7 @@ #ifndef MIGRAPHX_GUARD_RTGLIB_HIP_GEMM_IMPL_HPP #define MIGRAPHX_GUARD_RTGLIB_HIP_GEMM_IMPL_HPP +#include #include #include #include @@ -40,8 +41,8 @@ namespace gpu { using milliseconds = std::chrono::duration; using microseconds = std::chrono::duration; -void blas_shape_hip(const shape& in_shape); -shape transpose_batch_hip(const shape& s, unsigned trans_batch); +MIGRAPHX_GPU_EXPORT void blas_shape_hip(const shape& in_shape); +MIGRAPHX_GPU_EXPORT shape transpose_batch_hip(const shape& s, unsigned trans_batch); /** * @brief Templated implementations of the compute() and finalize() methods of the Gemm operator. From 8111fdc075627047a76b7fa8da58c029f7a55695 Mon Sep 17 00:00:00 2001 From: Shiv Date: Thu, 6 Aug 2026 16:17:16 -0700 Subject: [PATCH 3/5] add missing export --- src/targets/gpu/include/migraphx/gpu/prepare_mlir.hpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/targets/gpu/include/migraphx/gpu/prepare_mlir.hpp b/src/targets/gpu/include/migraphx/gpu/prepare_mlir.hpp index 36c053cc4c9..a5690955d9f 100644 --- a/src/targets/gpu/include/migraphx/gpu/prepare_mlir.hpp +++ b/src/targets/gpu/include/migraphx/gpu/prepare_mlir.hpp @@ -26,6 +26,7 @@ #define MIGRAPHX_GUARD_GPU_PREPARE_MLIR_HPP #include +#include #include namespace migraphx { @@ -35,7 +36,7 @@ struct module; namespace gpu { -struct prepare_mlir +struct MIGRAPHX_GPU_EXPORT prepare_mlir { std::string name() const { return "gpu::prepare_mlir"; } void apply(module& m) const; From c552793bf7ba559f2e56f04b35e1f4df7dc56168 Mon Sep 17 00:00:00 2001 From: Shiv Date: Thu, 6 Aug 2026 21:43:53 -0700 Subject: [PATCH 4/5] fix CI --- src/targets/gpu/compile_hipblaslt.cpp | 3 +++ src/targets/gpu/include/migraphx/gpu/compile_hipblaslt.hpp | 2 -- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/targets/gpu/compile_hipblaslt.cpp b/src/targets/gpu/compile_hipblaslt.cpp index c320e6b7dae..c63d5a3a9ab 100644 --- a/src/targets/gpu/compile_hipblaslt.cpp +++ b/src/targets/gpu/compile_hipblaslt.cpp @@ -25,6 +25,7 @@ #if MIGRAPHX_USE_HIPBLASLT #include #include +#include #include #include #include @@ -34,6 +35,8 @@ namespace migraphx { inline namespace MIGRAPHX_INLINE_NS { namespace gpu { +MIGRAPHX_REGISTER_OP(hipblaslt_op); + static size_t compile(migraphx::context& ctx, operation& op, instruction_ref ins) { auto v = op.compile(ctx, ins->get_shape(), to_shapes(ins->inputs())); diff --git a/src/targets/gpu/include/migraphx/gpu/compile_hipblaslt.hpp b/src/targets/gpu/include/migraphx/gpu/compile_hipblaslt.hpp index 05bb19f9102..7f21c3c2e97 100644 --- a/src/targets/gpu/include/migraphx/gpu/compile_hipblaslt.hpp +++ b/src/targets/gpu/include/migraphx/gpu/compile_hipblaslt.hpp @@ -27,7 +27,6 @@ #include #include #include -#include #include namespace migraphx { @@ -62,7 +61,6 @@ struct hipblaslt_op return {shapes.size() - 1}; } }; -MIGRAPHX_REGISTER_OP(hipblaslt_op); struct compile_hipblaslt { From f7f3cb5c240f09e1277b01b953273cefd9542941 Mon Sep 17 00:00:00 2001 From: Shiv Date: Thu, 6 Aug 2026 22:07:35 -0700 Subject: [PATCH 5/5] fix licensing and forward decl --- src/targets/gpu/compile_hipblaslt.cpp | 2 +- src/targets/gpu/include/migraphx/gpu/compile_hipblaslt.hpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/targets/gpu/compile_hipblaslt.cpp b/src/targets/gpu/compile_hipblaslt.cpp index c63d5a3a9ab..80daa54b25e 100644 --- a/src/targets/gpu/compile_hipblaslt.cpp +++ b/src/targets/gpu/compile_hipblaslt.cpp @@ -1,7 +1,7 @@ /* * The MIT License (MIT) * - * Copyright (c) 2015-2024 Advanced Micro Devices, Inc. All rights reserved. + * Copyright (c) 2015-2026 Advanced Micro Devices, Inc. All rights reserved. * * Permission is hereby granted, free of charge, to any person obtaining a copy * of this software and associated documentation files (the "Software"), to deal diff --git a/src/targets/gpu/include/migraphx/gpu/compile_hipblaslt.hpp b/src/targets/gpu/include/migraphx/gpu/compile_hipblaslt.hpp index 7f21c3c2e97..3ad029b3aec 100644 --- a/src/targets/gpu/include/migraphx/gpu/compile_hipblaslt.hpp +++ b/src/targets/gpu/include/migraphx/gpu/compile_hipblaslt.hpp @@ -27,6 +27,7 @@ #include #include #include +#include #include namespace migraphx { @@ -34,7 +35,6 @@ inline namespace MIGRAPHX_INLINE_NS { struct module; struct context; -struct operation; namespace gpu {