Skip to content

Commit fb1611d

Browse files
Simplify List creation (mostly in Test)
Replaces `Arrays.asList` and `Collections.singletonList` with `List.of`. Signed-off-by: Karsten Schnitter <[email protected]>
1 parent 6dd2374 commit fb1611d

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

cf-java-logging-support-opentelemetry-agent-extension/src/test/java/com/sap/hcf/cf/logging/opentelemetry/agent/ext/binding/CloudFoundryServicesAdapterTest.java

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,7 @@
66

77
import java.util.List;
88

9-
import static java.util.Arrays.asList;
109
import static java.util.Collections.emptyList;
11-
import static java.util.Collections.singletonList;
1210
import static java.util.stream.Collectors.toList;
1311
import static org.assertj.core.api.Assertions.assertThat;
1412

@@ -82,14 +80,14 @@ private static AbstractListAssert<?, List<? extends String>, String, ObjectAsser
8280
@Test
8381
void filtersBySingleLabel() {
8482
List<CloudFoundryServiceInstance> services =
85-
DEFAULT_ADAPTER.stream(singletonList("managed-find-me-service"), emptyList()).collect(toList());
83+
DEFAULT_ADAPTER.stream(List.of("managed-find-me-service"), emptyList()).collect(toList());
8684
assertServiceNames(services).containsExactlyInAnyOrder("managed-find-me1", "managed-find-me2", "managed-other");
8785
}
8886

8987
@Test
9088
void priotizesByServiceLabel() {
9189
List<CloudFoundryServiceInstance> services =
92-
DEFAULT_ADAPTER.stream(asList("user-provided", "managed-find-me-service"), emptyList())
90+
DEFAULT_ADAPTER.stream(List.of("user-provided", "managed-find-me-service"), emptyList())
9391
.collect(toList());
9492
assertServiceNames(services).containsExactly("ups-find-me1", "ups-find-me2", "ups-other", "managed-find-me1",
9593
"managed-find-me2", "managed-other");
@@ -98,15 +96,15 @@ void priotizesByServiceLabel() {
9896
@Test
9997
void filtersBySingleTag() {
10098
List<CloudFoundryServiceInstance> services =
101-
DEFAULT_ADAPTER.stream(emptyList(), singletonList("Find Me!")).collect(toList());
99+
DEFAULT_ADAPTER.stream(emptyList(), List.of("Find Me!")).collect(toList());
102100
assertServiceNames(services).containsExactlyInAnyOrder("managed-find-me1", "managed-find-me2", "managed-other1",
103101
"ups-find-me1", "ups-find-me2");
104102
}
105103

106104
@Test
107105
void standardUseCase() {
108106
List<CloudFoundryServiceInstance> services =
109-
DEFAULT_ADAPTER.stream(asList("user-provided", "managed-find-me-service"), singletonList("Find Me!"))
107+
DEFAULT_ADAPTER.stream(List.of("user-provided", "managed-find-me-service"), List.of("Find Me!"))
110108
.collect(toList());
111109
assertServiceNames(services).containsExactly("ups-find-me1", "ups-find-me2", "managed-find-me1",
112110
"managed-find-me2");

0 commit comments

Comments
 (0)