SLCORE-1858 Fix 'was ever updated' check for ServerFindingRepository

Author: kirill-knize-sonarsource

backend/server-connection/src/main/java/org/sonarsource/sonarlint/core/serverconnection/storage/ServerFindingRepository.java

@@ -64,12 +64,13 @@ public ServerFindingRepository(SonarLintDatabase database, String connectionId,
 
   @Override
   public boolean wasEverUpdated() {
-    // Limit to current connection/project scope
-    var rec = database.dsl().select(SERVER_BRANCHES.LAST_ISSUE_SYNC_TS).from(SERVER_BRANCHES)
+    return database.dsl().select(SERVER_BRANCHES.LAST_ISSUE_SYNC_TS, SERVER_BRANCHES.LAST_HOTSPOT_SYNC_TS, SERVER_BRANCHES.LAST_TAINT_SYNC_TS)
+      .from(SERVER_BRANCHES)
       .where(SERVER_BRANCHES.CONNECTION_ID.eq(connectionId)
         .and(SERVER_BRANCHES.SONAR_PROJECT_KEY.eq(sonarProjectKey)))
-      .fetchAny();
-    return rec != null && rec.value1() != null;
+      .fetchOptional()
+      .filter(r -> r.value1() != null || r.value2() != null || r.value3() != null)
+      .isPresent();
   }
 
   @Override

backend/server-connection/src/test/java/org/sonarsource/sonarlint/core/serverconnection/storage/ServerFindingRepositoryTests.java

@@ -192,6 +192,34 @@ void was_ever_updated() {
     assertThat(repo.wasEverUpdated()).isTrue();
   }
 
+  @Test
+  void was_ever_updated_for_no_issues() {
+    repo.replaceAllIssuesOfBranch(branch, List.of(), Set.of());
+
+    assertThat(repo.wasEverUpdated()).isTrue();
+  }
+
+  @Test
+  void was_never_updated() {
+    assertThat(repo.wasEverUpdated()).isFalse();
+  }
+
+  @Test
+  void was_ever_updated_when_only_hotspots_synced() {
+    var h1 = hotspot("HOTSPOT_KEY_1", filePath, 1, HotspotReviewStatus.TO_REVIEW, VulnerabilityProbability.MEDIUM, null);
+    repo.mergeHotspots(branch, List.of(h1), Set.of(), Instant.now(), Set.of());
+
+    assertThat(repo.wasEverUpdated()).isTrue();
+  }
+
+  @Test
+  void was_ever_updated_when_only_taints_synced() {
+    var t1 = taint("TAINT_KEY_1", filePath);
+    repo.mergeTaintIssues(branch, List.of(t1), Set.of(), Instant.now(), Set.of());
+
+    assertThat(repo.wasEverUpdated()).isTrue();
+  }
+
   @Test
   void update_issue_resolution_status() {
     var issueKey = "ISSUE_KEY";