Add more error checking for ftyp atom

KMojek · KMojek · commit 2191f92bd62d · 2024-10-28T14:05:41.000-04:00
diff --git a/src/atom_ftyp.cpp b/src/atom_ftyp.cpp
@@ -53,8 +53,8 @@ void MP4FtypAtom::Generate()
 
 void MP4FtypAtom::Read()
 {
-   if ( m_size == 0ULL )
-      return;
+   if ( m_size < 8ULL )
+      throw new Exception( "Invalid ftyp atom size", __FILE__, __LINE__, __FUNCTION__ );
 
     compatibleBrands.SetCount( (m_size - 8) / 4 ); // brands array fills rest of atom
     MP4Atom::Read();

Original file line number	Diff line number	Diff line change
`@@ -53,8 +53,8 @@ void MP4FtypAtom::Generate()`
`53`	`53`
`54`	`54`	`void MP4FtypAtom::Read()`
`55`	`55`	`{`
`56`		`- if ( m_size == 0ULL )`
`57`		`- return;`
	`56`	`+ if ( m_size < 8ULL )`
	`57`	`+ throw new Exception( "Invalid ftyp atom size", __FILE__, __LINE__, __FUNCTION__ );`
`58`	`58`
`59`	`59`	`compatibleBrands.SetCount( (m_size - 8) / 4 ); // brands array fills rest of atom`
`60`	`60`	`MP4Atom::Read();`