Skip to content

Commit a312538

Browse files
committed
Set compiler flags in CI workflow
These are the compiler flags used by libtopotoolbox. SWT will need to compile cleanly in order to be merged into libtopotoolbox, so we must resolve any compiler errors and warnings before moving forward. I have set the compiler to error on any warnings, which is somewhat strict, but will help us catch issues early on. We set the flags in the CI workflow, not in the Makefile, to allow consumers of this package to choose the appropriate flags. This way one can still develop SWT in the presence of compiler warnings, but you won't be able to contribute PRs until the compiler warnings are resolved and the PR checks pass. Signed-off-by: William Kearney <william.kearney@uni-potsdam.de>
1 parent d096473 commit a312538

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

.github/workflows/ci.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,6 @@ jobs:
1010
- name: Checkout repository
1111
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd
1212
- name: Build SWT
13-
run: make
13+
run: CFLAGS="-Werror -Wall -Wextra -Wpedantic -Wno-unused-parameter" make
1414
- name: Run tests
15-
run: make check
15+
run: make check

0 commit comments

Comments
 (0)