TopoToolbox V2 also labels closed basins in addition to flats and sills. If we can implement this, we can replace its identifyflats completely with the libtopotoolbox implementation. It uses imregionalmin along with some post processing, which should not be too challenging to incorporate into the main scan of identifyflats.
Note that DEMs that have been filled will not have any closed basins, so the existing property-based and snapshot tests will not be sufficient to test this implementation.
TopoToolbox V2 also labels closed basins in addition to flats and sills. If we can implement this, we can replace its
identifyflatscompletely with the libtopotoolbox implementation. It usesimregionalminalong with some post processing, which should not be too challenging to incorporate into the main scan ofidentifyflats.Note that DEMs that have been filled will not have any closed basins, so the existing property-based and snapshot tests will not be sufficient to test this implementation.