This repository was archived by the owner on Mar 14, 2021. It is now read-only.
Added diff to GraphQL generation test case.#11
Open
justinjoyn wants to merge 1 commit into
Open
Conversation
venkatd
reviewed
Oct 28, 2019
| expect(expectedResult, result); | ||
| DiffMatchPatch dmp = new DiffMatchPatch(); | ||
| List<Diff> differences = dmp.diff(expectedResult, result); | ||
| print( |
Contributor
There was a problem hiding this comment.
Shouldn't we be asserting something? Also ideally we check the actual diff contents.
Contributor
Author
There was a problem hiding this comment.
@venkatd Yes, we can check if the response is equal to the local file. But since we are comparing the local file to a remote response the output will fail for a small change in the GraphQL response. I added only the diff to simplify the output shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.