code review

[felzix]

Since it's already committed I don't seem to be able to do a proper code review. So I am doing it here. I didn't find anything actually wrong so take all of this with a grain of salt.

Smelter doesn't appear to be fully implemented.

https://github.com/MrTwiggy/MachineFactory/blob/master/src/com/github/MrTwiggy/MachineFactory/MachineFactoryPlugin.java

TICKS_PER_SECOND is unused and doesn't really make sense if you aren't running a repeated thread like mustercull does with DamageLaborer.

https://github.com/MrTwiggy/MachineFactory/blob/master/src/com/github/MrTwiggy/MachineFactory/Managers/OreGinManager.java#L100

(line 100) I believe you can do String line = [...].

https://github.com/MrTwiggy/MachineFactory/blob/master/src/com/github/MrTwiggy/MachineFactory/Managers/OreGinManager.java#L100

Purely for style I would && those if statements together to reduce the amount of nesting.

https://github.com/MrTwiggy/MachineFactory/blob/master/src/com/github/MrTwiggy/MachineFactory/Managers/OreGinManager.java#L100

I think it would be OK if you destroyed a reinforced machine if one block gets destroyed. I don't know if it's possible but it would actually make sense if reinforcing one block in a machine would reinforce the whole machine. Like a chest.

The way you're doing it is fine though.

https://github.com/MrTwiggy/MachineFactory/blob/master/src/com/github/MrTwiggy/MachineFactory/Listeners/OreGinListener.java#L286

Why can't entities blow up ore gins?

[ttk2]

Nice to see the code reviewed, could anyone get me a .jar?

[erocs]

I sent MrTiggy a couple comments. I'll send you a jar later tonight after he replies.

[pruby]

Could these check the block type before doing the machineExistsAt check like the BlockBreakEvent handler does?

https://github.com/MrTwiggy/MachineFactory/blob/master/src/com/github/MrTwiggy/MachineFactory/Listeners/OreGinListener.java#L235

https://github.com/MrTwiggy/MachineFactory/blob/master/src/com/github/MrTwiggy/MachineFactory/Listeners/OreGinListener.java#L284

Would cut down the number of lookups required, delay having to make machineExistsAt faster.