chore(linting): enable prefer-nullish-coalescing (@Miodec) (monkeytypegame#7209)

Author: Miodec

backend/src/api/controllers/dev.ts

@@ -221,7 +221,7 @@ async function updateUser(uid: string): Promise<void> {
       { sort: { wpm: -1, timestamp: 1 } },
     )) as DBResult;
 
-    if (personalBests[mode.mode] === undefined) personalBests[mode.mode] = {};
+    personalBests[mode.mode] ??= {};
     if (personalBests[mode.mode][mode.mode2] === undefined)
       personalBests[mode.mode][mode.mode2] = [];
 

backend/src/api/controllers/quote.ts

@@ -125,9 +125,7 @@ export async function submitRating(
     shouldUpdateRating,
   );
 
-  if (!userQuoteRatings[language]) {
-    userQuoteRatings[language] = {};
-  }
+  userQuoteRatings[language] ??= {};
   userQuoteRatings[language][quoteId] = rating;
 
   await updateQuoteRatings(uid, userQuoteRatings);

backend/src/api/controllers/result.ts

@@ -170,24 +170,12 @@ export async function updateTags(
   await ResultDAL.updateTags(uid, resultId, tagIds);
   const result = await ResultDAL.getResult(uid, resultId);
 
-  if (!result.difficulty) {
-    result.difficulty = "normal";
-  }
-  if (!(result.language ?? "")) {
-    result.language = "english";
-  }
-  if (result.funbox === undefined) {
-    result.funbox = [];
-  }
-  if (!result.lazyMode) {
-    result.lazyMode = false;
-  }
-  if (!result.punctuation) {
-    result.punctuation = false;
-  }
-  if (!result.numbers) {
-    result.numbers = false;
-  }
+  result.difficulty ??= "normal";
+  result.language ??= "english";
+  result.funbox ??= [];
+  result.lazyMode ??= false;
+  result.punctuation ??= false;
+  result.numbers ??= false;
 
   const user = await UserDAL.getPartialUser(uid, "update tags", ["tags"]);
   const tagPbs = await UserDAL.checkIfTagPb(uid, user, result);

backend/src/dal/result.ts

@@ -21,7 +21,7 @@ export async function addResult(
   const { data: user } = await tryCatch(getUser(uid, "add result"));
 
   if (!user) throw new MonkeyError(404, "User not found", "add result");
-  if (result.uid === undefined) result.uid = uid;
+  result.uid ??= uid;
   // result.ir = true;
   const res = await getResultCollection().insertOne(result);
   return {

backend/src/dal/user.ts

@@ -275,7 +275,7 @@ export async function findByName(name: string): Promise<DBUser | undefined> {
     { collation: { locale: "en", strength: 1 } },
   );
 
-  return found !== null ? found : undefined;
+  return found ?? undefined;
 }
 
 export async function isNameAvailable(
@@ -1053,10 +1053,14 @@ export async function updateInbox(
                 .filter((it) => it.type === "badge")
                 .map((it) => it.item);
 
+              // mongo doesnt support ??= i think
+              // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
               if (inventory === null)
                 inventory = {
                   badges: [],
                 };
+              // mongo doesnt support ??= i think
+              // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
               if (inventory.badges === null) inventory.badges = [];
 
               const uniqueBadgeIds = new Set();

backend/src/jobs/update-leaderboards.ts

@@ -46,7 +46,7 @@ async function updateLeaderboardAndNotifyChanges(
     const isRecentRecord =
       record.timestamp > Date.now() - RECENT_AGE_MILLISECONDS;
 
-    return (userImprovedRank || newUserInTop10) && isRecentRecord;
+    return (userImprovedRank === true || newUserInTop10) && isRecentRecord;
   });
 
   if (newRecords.length > 0) {

backend/src/middlewares/auth.ts

@@ -60,7 +60,8 @@ export function authenticateTsRestRequest<
     let authType = "None";
 
     const isPublic =
-      options.isPublic || (options.isPublicOnDev && isDevEnvironment());
+      options.isPublic === true ||
+      (options.isPublicOnDev && isDevEnvironment());
 
     const {
       authorization: authHeader,
@@ -241,7 +242,7 @@ async function authenticateWithApeKey(
   options: RequestAuthenticationOptions,
 ): Promise<DecodedToken> {
   const isPublic =
-    options.isPublic || (options.isPublicOnDev && isDevEnvironment());
+    options.isPublic === true || (options.isPublicOnDev && isDevEnvironment());
 
   if (!isPublic) {
     if (!configuration.apeKeys.acceptKeys) {

backend/src/utils/misc.ts

@@ -195,9 +195,7 @@ export function isDevEnvironment(): boolean {
 export function getFrontendUrl(): string {
   return isDevEnvironment()
     ? "http://localhost:3000"
-    : process.env["FRONTEND_URL"] !== undefined
-      ? process.env["FRONTEND_URL"]
-      : "https://monkeytype.com";
+    : (process.env["FRONTEND_URL"] ?? "https://monkeytype.com");
 }
 
 /**

frontend/src/ts/controllers/chart-controller.ts

@@ -594,10 +594,7 @@ export const accountHistory = new ChartWithUpdateColors<
                 label += resultData.mode2;
               }
 
-              let diff = resultData.difficulty;
-              if (diff === undefined) {
-                diff = "normal";
-              }
+              let diff = resultData.difficulty ?? "normal";
               label += `\ndifficulty: ${diff}`;
 
               label +=

frontend/src/ts/controllers/pw-ad-controller.ts

@@ -146,11 +146,11 @@ export function init(): void {
   headOfDocument.appendChild(rampScript);
 
   window._pwGA4PageviewId = "".concat(Date.now());
-  // eslint-disable-next-line @typescript-eslint/strict-boolean-expressions, @typescript-eslint/no-unsafe-assignment
+  // eslint-disable-next-line @typescript-eslint/strict-boolean-expressions, @typescript-eslint/no-unsafe-assignment, @typescript-eslint/prefer-nullish-coalescing
   window.dataLayer = window.dataLayer || [];
   // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
   window.gtag =
-    // eslint-disable-next-line @typescript-eslint/strict-boolean-expressions
+    // eslint-disable-next-line @typescript-eslint/strict-boolean-expressions, @typescript-eslint/prefer-nullish-coalescing
     window.gtag ||
     function (): void {
       // eslint-disable-next-line prefer-rest-params