Misc Rust Fixes & Improvements #7752
Draft
+2,435
−1,759
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forgot to call `BNFreeArchitectureAndAddressList`, also use `Location` instead of `ArchAndAddr`.
Use `Location` instead, `arch` can be a nullptr
To keep backwards compatibility for commonly referenced code we re-export them within the architecture module. Also does some light refactoring of some newly added APIs to keep them more consistent with other parts of the codebase.
There was a TODO there to document that it is optional, we should just wrap it in `Option` instead.
Still need to add a custom architecture for unit tests like in python
emesare
force-pushed
the
test_rust_misc_fixes_0
branch
from
644791c to
04c8df1
Compare
- `analysis_info` was causing a double free with function refs, also did not need to be wrapped in a Result
emesare
force-pushed
the
test_rust_misc_fixes_0
branch
from
37b97cf to
bf012e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch addresses some miscellaneous bugs, as well as code smells such as duplicate APIs and large unstructured modules. The intention with this is to keep breaking changes of well used APIs to a minimum, although APIs which are likely unused by external users (e.g. no known consumer other than internal use like tests or bundled plugins).
APIs inside the
architecturemodule were re-exported after they were moved so this is more or less just a DX change, for those reading the crates documentation or maintaining thearchitecturemodule.