Commit 7f72e87
committed
test(signing): assert the reject code, not just the refusal
The reject branch asserted a bare ValueError -- but urlsplit raises exactly
that for `https://[::1/p`, so `malformed-ipv6-missing-closing-bracket` passed
on someone else's exception while five sibling cases sat in the xfail ledger.
Six reject cases ship in the data; only five were recorded as gaps.
No case asserted `expected_error_code` at all, so the vector set could not
detect its own incompleteness -- the defect this PR exists to close.
Capture the exception and assert the code the vector ships. All six reject
cases now xfail together under #978 and retire together when the typed error
lands.1 parent 0b9477d commit 7f72e87
1 file changed
Lines changed: 17 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
45 | 45 | | |
46 | 46 | | |
47 | 47 | | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
48 | 54 | | |
49 | 55 | | |
50 | 56 | | |
| |||
104 | 110 | | |
105 | 111 | | |
106 | 112 | | |
107 | | - | |
108 | | - | |
109 | | - | |
110 | | - | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
111 | 119 | | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
112 | 125 | | |
113 | 126 | | |
114 | 127 | | |
| |||
0 commit comments