Skip to content

Commit d719b5c

Browse files
test(signing): re-pin the vendored vectors at AdCP 3.1.8
Review follow-up. main moved to 3.1.8 (#992) while this branch pinned 3.1.1, so test_manifest_pins_the_spec_version_the_sdk_targets failed once the two met. Only spec_version and source change: the 3.1.1 and 3.1.8 dist/compliance/.../test-vectors/request-signing trees are byte-identical, and regenerating the manifest reproduces all 43 file hashes unchanged. That is the pin doing its job -- it forced an explicit re-vendor decision on a spec bump rather than letting the old set ride silently. Note for the next bump: `python -m tests.conformance.signing.vectors --write` regenerates `files` only and carries spec_version/source forward, so those two fields need editing before the regen, not by it. Refs #975.
1 parent 0712389 commit d719b5c

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

tests/conformance/signing/vector_manifest.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"$comment": "Completeness pin for the vendored AdCP request-signing conformance vectors. Generated by `python -m tests.conformance.signing.vectors --write`; do not hand-edit. Graded by tests/conformance/signing/test_vector_completeness.py.",
3-
"spec_version": "3.1.1",
4-
"source": "adcontextprotocol/adcp @ v3.1.1 -- dist/compliance/3.1.1/test-vectors/request-signing/",
3+
"spec_version": "3.1.8",
4+
"source": "adcontextprotocol/adcp @ v3.1.8 -- dist/compliance/3.1.8/test-vectors/request-signing/",
55
"files": {
66
"README.md": "74977dcb44eef69aee2b45e78e9fc111625e101d7e8646ed9f44b521aee396e8",
77
"canonicalization.json": "83a15584bebb0ff006ffd99a4080f5a922ea56e9e590d516ee87becaaf15ad1b",

0 commit comments

Comments
 (0)