Skip to content

feat(server): webhook supervisor signing + capabilities response invariant for reporting webhooks #384

Description

@bokelley

Context

protocol/get-adcp-capabilities-response.json line 996 expresses an invariant: when a seller declares reporting webhooks in its capabilities, outbound webhook delivery MUST sign requests per RFC 9421. The framework already provides PgWebhookDeliverySupervisor (#360), but the actual signing wiring is currently the adopter's responsibility, and there is no boot-time check that the capabilities declaration matches the supervisor configuration.

Refs:

  • protocol/get-adcp-capabilities-response.json:996
  • src/adcp/decisioning/pg/ (PgWebhookDeliverySupervisor)
  • examples/v3_reference_seller/src/app.py

Acceptance Criteria

  • Document the RFC 9421 signing wiring in v3 ref seller (key material loading, key id, algorithm selection)
  • Wire signing into the v3 ref seller's webhook supervisor instance
  • Boot-time validator: if the platform's capabilities response declares any reporting webhook, fail boot unless the supervisor is configured with a signing key
  • Test: verify outbound webhook bodies actually carry the RFC 9421 Signature and Signature-Input headers
  • Test: verify boot fails when capabilities declare webhooks but supervisor has no key configured

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions