Skip to content

Inconsistencies with PUT requests in superpaths #569

@mjacoby

Description

@mjacoby

What is the issue?

According to the specification there are the following API calls ralted to PUT a submodel:

For AAS it follows the same pattern

In the OpenAPI documentation for the complete API are following mappings of these operations:

For AAS it follows mostly the same pattern but there are some minor differences

Why is this wrong?

The OpenAPI definition is inconsistent in two ways

  1. The two submodel calls behave differently although they are, to my understanding, essentially the same call, at least in the SubmodelRepository interface because there no longer is a seperate /submodel call because of superpaths.
  2. API for submodels (one call returns 204 and the other 201) is different than for AAS (both calls can return both 201 and 204)

How should it be fixed?

Apply the pattern used for AAS also for submodels, i.e., change PUT /submodel and PUT /submodels/{submodelIdentifier} to both support create and update and therefore return 201 resp. 204.

  • I have signed the required Developer Certificate of Origin (DCO) already.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions