Just a big thank you for this tool (January 2025)

[m040601]

This is not a github issue or problem report. It is just a thank you for Ali Rudi.

I noticed today, 2025-01-10, 2 small commits after a 2 year "silence". So the tool is alive, watched for, and well maintained.

035ff3e  5h Ali Gholami Rudi   o [master] {origin/master} {origin/HEAD} fbpdf: compute text l
d57bb2d  6h Ali Gholami Rudi   o doc.h: remove fbval_t type
6276360  2Y Lu Xu              o fbpdf.1: update and improve the manual page
ba231d2  2Y 4D617278           o poppler: return NULL from doc_open() if malloc() fails
88dec44  3Y Ali Gholami Rudi   o draw: read FBDEV environment variable
f590024  4Y Ali Gholami Rudi   o fbpdf: more accurate mark vertical position after recent cha
.....
c0672ee 12Y Ali Gholami Rudi   o fbpdf: add fit to width and fit to height command
49def6e 12Y Ali Gholami Rudi   o mupdf: define a private MIN() macro

I'm on Arch Linux using it with the "mupdf" backend and building from git, https://aur.archlinux.org/packages/fbpdf-git.

Everything works fine after 12 years.

It is just a thank you for your work, maintaining this very usefull tool all
these years.

And to let you know, that there are many people for whom this and other of you
framebuffer utilities are very appreciated and used. Even if most people are silent or dont give feedback.

[LaptopDev]

Hey I know this is probably not the correct place to put this I could open a new issue if that might be preferable but how are you installing mupdf and setting your makefile?

I have tried the AUR package and get the same exact behavior of empty output in my kitty terminal. What terminal are you using?

[aligrudi]

somename123 ***@***.***> wrote:

I noticed today, 2025-01-10, 2 small commits after a 2 year "silence". So the tool is alive, watched for, and well maintained. ``` 035ff3e 5h Ali Gholami Rudi o [master] {origin/master} {origin/HEAD} fbpdf: compute text l d57bb2d 6h Ali Gholami Rudi o doc.h: remove fbval_t type 6276360 2Y Lu Xu o fbpdf.1: update and improve the manual page ba231d2 2Y 4D617278 o poppler: return NULL from doc_open() if malloc() fails 88dec44 3Y Ali Gholami Rudi o draw: read FBDEV environment variable f590024 4Y Ali Gholami Rudi o fbpdf: more accurate mark vertical position after recent cha ...... c0672ee 12Y Ali Gholami Rudi o fbpdf: add fit to width and fit to height command 49def6e 12Y Ali Gholami Rudi o mupdf: define a private MIN() macro ```

I use it daily myself. Just updated the copyright year to show that it is maintained.

I'm on Arch Linux using it with the "mupdf" backend and building from git, https://aur.archlinux.org/packages/fbpdf-git. Everything works fine after 12 years. It is just a thank you for your work, maintaining this very usefull tool all these years. And to let you know, that there are many people for whom this and other of you framebuffer utilities are very appreciated and used. Even if most people are silent or dont give feedback.

Glad to year that. As a bonus, you can optimize framebuffer updates after the recent changes as follows: ``` diff --git a/mupdf.c b/mupdf.c index 2463041..8156241 100644 --- a/mupdf.c +++ b/mupdf.c @@ -10,6 +10,13 @@ struct doc { fz_document *pdf; }; +static void fb_set2(char *d, unsigned r, unsigned g, unsigned b) +{ + d[0] = b; + d[1] = g; + d[2] = r; +} + void *doc_draw(struct doc *doc, int page, int zoom, int rotate, int bpp, int *rows, int *cols) { fz_matrix ctm; @@ -30,7 +37,7 @@ void *doc_draw(struct doc *doc, int page, int zoom, int rotate, int bpp, int *ro unsigned char *s = &pix->samples[y * pix->stride]; char *d = pbuf + (y * pix->w) * bpp; for (x = 0; x < pix->w; x++) - fb_set(d + x * bpp, s[x * pix->n], s[x * pix->n + 1], s[x * pix->n + 2]); + fb_set2(d + x * bpp, s[x * pix->n], s[x * pix->n + 1], s[x * pix->n + 2]); } fz_drop_pixmap(doc->ctx, pix); *cols = pix->w; ``` You may need to change fb_set2 to match the pixel format of your framebuffer device (it is for a little endian 32-bit framebuffer). Ali

[aligrudi]

LaptopDev ***@***.***> wrote:

I have tried the AUR package and get the same exact behavior of empty output in my kitty terminal. What terminal are you using?

Fbpdf won't work, if X is running. Ali