Skip to content

## Pull request overview #2

Description

@jibsonzamani217-web

Pull request overview

This PR introduces a new isPending prop across several UI components (Alert, Button, ButtonIcon, Table, TableRoot) to align with React Aria naming, while keeping the existing loading prop as a deprecated alias. It also updates styling hooks and documentation/stories to use the new naming.

Changes:

  • Add isPending?: boolean to public component props and refactor internal Table pagination state from loading to isPending.
  • Update CSS selectors from data-loading to data-ispending and update component implementations to set/consume the new data attribute.
  • Update stories, docs-ui content, and add a changeset documenting the deprecation and migration.

Reviewed changes

Copilot reviewed 42 out of 42 changed files in this pull request and generated 9 comments.

Show a summary per file
File Description
packages/ui/src/components/Table/types.ts Adds isPending + deprecates loading on Table prop types.
packages/ui/src/components/Table/stories/Table.visual.stories.tsx Updates story usage from loading to isPending.
packages/ui/src/components/Table/hooks/useTable.ts Renames table hook output to isPending while keeping loading alias.
packages/ui/src/components/Table/hooks/usePageCache.ts Renames internal cache state from loading to isPending.
packages/ui/src/components/Table/hooks/useOffsetPagination.ts Updates pagination result mapping to isPending.
packages/ui/src/components/Table/hooks/useCursorPagination.ts Updates pagination result mapping to isPending.
packages/ui/src/components/Table/hooks/useCompletePagination.ts Updates complete-pagination result to isPending.
packages/ui/src/components/Table/hooks/types.ts Renames PaginationResult.loading to isPending.
packages/ui/src/components/Table/definition.ts Adds isPending as a data-attribute prop on TableRoot.
packages/ui/src/components/Table/components/TableRoot.tsx Uses isPending for aria-busy and merges deprecated loading.
packages/ui/src/components/Table/components/Table.tsx Adds isPending prop and maps pending state to TableRoot.
packages/ui/src/components/Table/Table.module.css Switches styling selectors to data-ispending.
packages/ui/src/components/ButtonIcon/types.ts Adds isPending + deprecates loading.
packages/ui/src/components/ButtonIcon/definition.ts Adds isPending data attribute prop.
packages/ui/src/components/ButtonIcon/ButtonIcon.tsx Merges deprecated loading into isPending for RAButton.
packages/ui/src/components/ButtonIcon/ButtonIcon.stories.tsx Updates stories naming/props to pending terminology.
packages/ui/src/components/ButtonIcon/ButtonIcon.module.css Switches styling selectors to data-ispending.
packages/ui/src/components/Button/types.ts Adds isPending + deprecates loading.
packages/ui/src/components/Button/definition.ts Adds isPending data attribute prop.
packages/ui/src/components/Button/Button.tsx Merges deprecated loading into isPending for RAButton.
packages/ui/src/components/Button/Button.stories.tsx Updates stories naming/props to pending terminology.
packages/ui/src/components/Button/Button.module.css Switches styling selectors to data-ispending.
packages/ui/src/components/Alert/types.ts Adds isPending + deprecates loading.
packages/ui/src/components/Alert/definition.ts Adds isPending data attribute prop.
packages/ui/src/components/Alert/Alert.tsx Merges deprecated loading into isPending and renders spinner based on pending.
packages/ui/src/components/Alert/Alert.stories.tsx Updates stories/controls to use isPending.
packages/ui/report.api.md Updates extracted API report to include isPending additions.
docs-ui/src/app/components/table/props-definition.tsx Updates docs prop tables for isPending and deprecates loading.
docs-ui/src/app/components/table/page.mdx Renames docs content to “Pending” terminology and references tableProps.isPending.
docs-ui/src/app/components/button/snippets.ts Updates snippet variable/name to isPending.
docs-ui/src/app/components/button/props-definition.tsx Documents new isPending and deprecates loading.
docs-ui/src/app/components/button/page.mdx Updates docs section and snippet imports to pending naming.
docs-ui/src/app/components/button/components.tsx Updates example component to use isPending.
docs-ui/src/app/components/button-icon/snippets.ts Updates snippet to use isPending.
docs-ui/src/app/components/button-icon/props-definition.tsx Documents new isPending and deprecates loading.
docs-ui/src/app/components/button-icon/page.mdx Updates docs section and snippet imports to pending naming.
docs-ui/src/app/components/button-icon/components.tsx Updates example component to use isPending.
docs-ui/src/app/components/alert/snippets.ts Updates snippets to use isPending.
docs-ui/src/app/components/alert/props-definition.ts Documents isPending and marks loading as deprecated in docs.
docs-ui/src/app/components/alert/page.mdx Updates docs section and snippet imports to pending naming.
docs-ui/src/app/components/alert/components.tsx Updates example component to use isPending.
.changeset/brave-groups-learn.md Adds changeset describing isPending introduction and loading deprecation.

Originally posted by @copilot-pull-request-reviewer in backstage/backstage#33986 (review)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions