Add prompts loader tests and lazy command build for CLAUDE.md fixer

Signed-off-by: ddjain <darjain@redhat.com>

Author: ddjain

CLAUDE.md

@@ -46,6 +46,7 @@ src/agentready/
 ├── reporters/       # Report generation (HTML, Markdown, JSON)
 │   ├── html.py      # Interactive HTML with Jinja2
 │   └── markdown.py  # GitHub-Flavored Markdown
+├── prompts/        # LLM prompt .md templates; load_prompt(name) from loader.py
 ├── templates/       # Jinja2 templates
 │   └── report.html.j2  # Self-contained HTML report (73KB)
 └── cli/             # Click-based CLI

src/agentready/fixers/documentation.py

@@ -33,9 +33,6 @@ def _claude_md_command() -> str:
         ]
     )
 
-# Command run by CLAUDEmdFixer to generate CLAUDE.md via Claude CLI
-CLAUDE_MD_COMMAND = _claude_md_command()
-
 
 class _ClaudeMdToAgentRedirectFix(Fix):
     """Post-step fix: move CLAUDE.md content to AGENTS.md, replace CLAUDE.md with @AGENTS.md."""
@@ -152,7 +149,7 @@ def generate_fix(self, repository: Repository, finding: Finding) -> Optional[Fix
             attribute_id=self.attribute_id,
             description="Run Claude CLI to create CLAUDE.md in the project",
             points_gained=points,
-            command=CLAUDE_MD_COMMAND,
+            command=_claude_md_command(),
             working_dir=repository.path,
             repository_path=repository.path,
             capture_output=False,  # Stream Claude output to terminal

src/agentready/prompts/__init__.py

@@ -1,7 +1,5 @@
 """LLM prompt templates loaded from package resources."""
 
-import importlib.resources
-
 from .loader import load_prompt
 
 __all__ = ["load_prompt"]

tests/unit/test_fixers.py

@@ -9,10 +9,10 @@
 
 from agentready.fixers.documentation import (
     ANTHROPIC_API_KEY_ENV,
-    CLAUDE_MD_COMMAND,
     CLAUDE_MD_REDIRECT_LINE,
     CLAUDEmdFixer,
     GitignoreFixer,
+    _claude_md_command,
 )
 from agentready.models.attribute import Attribute
 from agentready.models.finding import Finding, Remediation
@@ -107,6 +107,14 @@ def gitignore_failing_finding():
     )
 
 
+def test_claude_md_command_shell_safe():
+    """_claude_md_command returns a command with shell-quoted arguments."""
+    cmd = _claude_md_command()
+    assert "claude" in cmd
+    assert "-p" in cmd
+    assert "'" in cmd or '"' in cmd  # shlex.quote applied
+
+
 class TestCLAUDEmdFixer:
     """Tests for CLAUDEmdFixer."""
 
@@ -142,7 +150,7 @@ def test_generate_fix_when_agent_md_missing(
         assert isinstance(fix, MultiStepFix)
         assert len(fix.steps) == 2
         assert isinstance(fix.steps[0], CommandFix)
-        assert fix.steps[0].command == CLAUDE_MD_COMMAND
+        assert fix.steps[0].command == _claude_md_command()
         assert fix.steps[0].working_dir == temp_repo.path
         assert fix.steps[0].capture_output is False
         assert fix.attribute_id == "claude_md_file"

tests/unit/test_prompts_loader.py

@@ -0,0 +1,37 @@
+"""Unit tests for prompts loader."""
+
+import importlib.resources
+
+import pytest
+
+from agentready.prompts import load_prompt
+
+
+def test_load_prompt_success():
+    """load_prompt returns content for existing prompt file."""
+    content = load_prompt("claude_md_generator")
+    assert content
+    assert "senior technical documentation architect" in content
+    assert "CLAUDE.md" in content
+
+
+def test_load_prompt_invalid_name_raises_value_error():
+    """load_prompt raises ValueError for names with path separators or leading dot."""
+    with pytest.raises(ValueError, match="Invalid prompt name"):
+        load_prompt("../malicious")
+    with pytest.raises(ValueError, match="Invalid prompt name"):
+        load_prompt("foo/bar")
+    with pytest.raises(ValueError, match="Invalid prompt name"):
+        load_prompt(".hidden")
+
+
+def test_load_prompt_missing_file_raises_file_not_found_error():
+    """load_prompt raises FileNotFoundError for non-existent prompt."""
+    with pytest.raises(FileNotFoundError, match="nonexistent_prompt"):
+        load_prompt("nonexistent_prompt")
+
+
+def test_prompts_packaged_correctly():
+    """Ensure .md prompt files are included in package distribution."""
+    ref = importlib.resources.files("agentready.prompts")
+    assert (ref / "claude_md_generator.md").is_file()